Wrap render method created using class properties. #850
Conversation
arunoda
changed the title
client/patch-react.js
Outdated
| const _render = function (...args) { | ||
| try { | ||
| return render.apply(this, args) | ||
| return render.apply(context || this, args) |
There was a problem hiding this comment.
I wonder why we need context
There was a problem hiding this comment.
Yep. We don't need this.
| } | ||
|
|
||
| this.render = wrapRender(this.render, this) | ||
| } |
There was a problem hiding this comment.
We should redefine constructor instead of using componentDidMount ?
There was a problem hiding this comment.
I'm quite not sure about that. This constructor function is something generated by babel. I just used that to detect a React component.
client/patch-react.js
Outdated
| originalComponentWillMount.apply(this, args) | ||
| } | ||
|
|
||
| this.render = wrapRender(this.render, this) |
There was a problem hiding this comment.
I think we should do this only when this.render didn't come from prototype.
There was a problem hiding this comment.
I think that's how it works. If there's a render method, it'll get wrapped by the above if block.
Did you mean something else?
| if (prototype && prototype.render) { | ||
| prototype.render = wrapRender(prototype.render) | ||
| } else if (prototype && prototype.constructor) { | ||
| // Still a React component instance, but there's no render method in |
There was a problem hiding this comment.
btw there may be render but might override it on constructor.
class Foo extends React.Component {
render () {}
}
class Bar extends Foo {
render = () => {};
}There was a problem hiding this comment.
Since we do this on the componentWillMount. I assume this is fine.
Isn't it?
There was a problem hiding this comment.
For now, we don't monkeypatch componentWillMount if prototype.render exists.
arunoda
changed the title
|
alternate PR #856 |
2 participants
Fixes #828
With this, we are wrapping the render method added using ES2016+ class properties.
It doesn't add the render method to class's prototype. So, that's why we need to do this.