Skip to content

Conversation

@mischnic
Copy link
Contributor

@mischnic mischnic commented Sep 15, 2025

Backport #82911

Closes PACK-5480

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. tests Turbopack Related to Turbopack with Next.js. labels Sep 15, 2025
@mischnic mischnic requested a review from a team September 15, 2025 12:06
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 15, 2025

CodSpeed Instrumentation Performance Report

Merging #83804 will degrade performances by 7.41%

Comparing mischnic/backport-85ef363 (965bb6b) with canary (287b763)1

🎉 Hooray! codspeed-rust just leveled up to 2.10.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 9 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
build[date-fns-all] 2.2 s 2.3 s -5.39%
build[date-fns-single] 1.3 s 1.4 s -4.94%
build[framer-motion-all] 3 s 3.2 s -7.41%
build[framer-motion-single] 2.1 s 2.3 s -6.91%
build[joy] 2 s 2.1 s -5.53%
build[lucide-react-all] 8.6 s 9.2 s -7.24%
build[lucide-react-single] 863.1 ms 910 ms -5.15%
build[mui] 3 s 3.2 s -6.04%
build[shiki] 5.9 s 6.1 s -3.71%

Footnotes

  1. No successful run was found on next-15-5 (050bdf1) during the generation of this report, so canary (287b763) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ijjk
Copy link
Member

ijjk commented Sep 15, 2025

Tests Passed

Copy link

@krsjenswbp krsjenswbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thạnks

Metadata routes are just `route.ts`\-s in diguise.
Treat them the same regarding the layer (`app-route`) and whether to emit client reference/server actions manifests for them (= don't).

This fixes a panic:

```
thread 'tokio-runtime-worker' panicked at crates/next-api/src/dynamic_imports.rs:70:26:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```

https://vercel.slack.com/archives/C05TH5T3DS8/p1755670936074369
@mischnic mischnic force-pushed the mischnic/backport-85ef363 branch from 5eff82f to 965bb6b Compare September 17, 2025 17:02
@mischnic mischnic merged commit 7a53950 into next-15-5 Sep 17, 2025
265 of 269 checks passed
@mischnic mischnic deleted the mischnic/backport-85ef363 branch September 17, 2025 18:48
@github-actions github-actions bot added the locked label Oct 2, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants