Skip to content

Don’t use native built-ins for additional bundler #76577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Don’t use native built-ins for additional bundler #76577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/rspack-nextjs-build-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,7 @@ jobs:
name: rspack-production
test_type: production
run_before_test: |
export NEXT_RSPACK=1 \
NEXT_TEST_USE_RSPACK=1 \
BUILTIN_FLIGHT_CLIENT_ENTRY_PLUGIN=1 \
BUILTIN_APP_LOADER=1 \
BUILTIN_SWC_LOADER=1
export NEXT_RSPACK=1 NEXT_TEST_USE_RSPACK=1 \
# Failing tests take longer (due to timeouts and retries). Since we have
# many failing tests, we need smaller groups and longer timeouts, in case
# a group gets stuck with a cluster of failing tests.
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/rspack-nextjs-dev-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,7 @@ jobs:
name: rspack-development
test_type: development
run_before_test: |
export NEXT_RSPACK=1 \
NEXT_TEST_USE_RSPACK=1 \
BUILTIN_FLIGHT_CLIENT_ENTRY_PLUGIN=1 \
BUILTIN_APP_LOADER=1 \
BUILTIN_SWC_LOADER=1
export NEXT_RSPACK=1 NEXT_TEST_USE_RSPACK=1
# Failing tests take longer (due to timeouts and retries). Since we have
# many failing tests, we need smaller groups and longer timeouts, in case
# a group gets stuck with a cluster of failing tests.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"storybook": "turbo run storybook",
"build-storybook": "turbo run build-storybook",
"test-storybook": "turbo run test-storybook",
"with-rspack": "cross-env NEXT_RSPACK=1 NEXT_TEST_USE_RSPACK=1 BUILTIN_FLIGHT_CLIENT_ENTRY_PLUGIN=1 BUILTIN_APP_LOADER=1 BUILTIN_SWC_LOADER=1"
"with-rspack": "cross-env NEXT_RSPACK=1 NEXT_TEST_USE_RSPACK=1"
},
"devDependencies": {
"@actions/core": "1.10.1",
Expand Down
4 changes: 1 addition & 3 deletions packages/next-plugin-rspack/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
module.exports = function withRspack(config) {
process.env.NEXT_RSPACK = 'true'
process.env.BUILTIN_FLIGHT_CLIENT_ENTRY_PLUGIN = 'true'
process.env.BUILTIN_APP_LOADER = 'true'
process.env.BUILTIN_SWC_LOADER = 'true'
process.env.RSPACK_CONFIG_VALIDATE = 'loose-silent'
return config
}
4 changes: 1 addition & 3 deletions test/lib/create-next-install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,7 @@ async function createNextInstall({
// This is what the @next/plugin-rspack plugin does.
// TODO: Load the plugin properly during test
process.env.NEXT_RSPACK = 'true'
process.env.BUILTIN_FLIGHT_CLIENT_ENTRY_PLUGIN = 'true'
process.env.BUILTIN_APP_LOADER = 'true'
process.env.BUILTIN_SWC_LOADER = 'true'
process.env.RSPACK_CONFIG_VALIDATE = 'loose-silent'
}

return {
Expand Down
Loading