[Docs]: USe wbr to break a long title on mobile #74076
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Next.js DevEx team
leerob
reviewed
Dec 18, 2024
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| title: serverComponentsHmrCache | |||
| title: serverComponents<wbr />HmrCache | |||
There was a problem hiding this comment.
I think this gets read directly for metadata, so this might not work
There was a problem hiding this comment.
I dont think it does, i checked the code in front repo:
- Metadata: https://github.com/vercel/front/blob/21452fe520f46a65ee14838809f8d1f052160748/apps/next-site/app/(next-site)/docs/%5B%5B...slug%5D%5D/page.tsx#L97
- Rendering page title: https://github.com/vercel/front/blob/21452fe520f46a65ee14838809f8d1f052160748/apps/next-site/app/(next-site)/docs/%5B%5B...slug%5D%5D/page.tsx#L278
There was a problem hiding this comment.
Hmm, im not actually sure, as its hooked into content layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title for this page https://nextjs.org/docs/app/api-reference/config/next-config-js/serverComponentsHmrCache is too long on mobile and causes overflow. This PR encodes the
<wbr/>element (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr) to attempt to solve.