Skip to content

fix(turbo): sassOptions silenceDeprecations was not overwritten with user options #73937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devjiwonchoi merged 1 commit into from
Dec 14, 2024
Merged

fix(turbo): sassOptions silenceDeprecations was not overwritten with user options #73937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/next-core/src/next_shared/webpack_rules/sass.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,13 @@ pub async fn maybe_add_sass_loader(
bail!("sass_options must be an object");
};
// TODO: Remove this once we upgrade to sass-loader 16
sass_options.insert(
"silenceDeprecations".into(),
serde_json::json!(["legacy-js-api"]),
);
let silence_deprecations = if let Some(v) = sass_options.get("silenceDeprecations") {
v.clone()
} else {
serde_json::json!(["legacy-js-api"])
};

sass_options.insert("silenceDeprecations".into(), silence_deprecations);
let mut rules = if let Some(webpack_rules) = webpack_rules {
webpack_rules.await?.clone_value()
} else {
Expand Down
Loading