Skip to content

Add warning when running start without build #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 11, 2017
Merged

Add warning when running start without build #736

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aaedc11
add warning when running start without build
ntwcklng Jan 11, 2017
171b544
run build before start
ntwcklng Jan 11, 2017
a9951bf
Revert "run build before start"
ntwcklng Jan 11, 2017
e628491
exit code & dir
ntwcklng Jan 11, 2017
3289508
dont update yarn.lock
ntwcklng Jan 11, 2017
3c4c5e2
use existsSync
ntwcklng Jan 11, 2017
430e269
Add some style changes.
arunoda Jan 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion bin/next-start
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import { resolve } from 'path'
import parseArgs from 'minimist'
import Server from '../server'
import {exists} from 'mz/fs'

const argv = parseArgs(process.argv.slice(2), {
alias: {
Expand Down Expand Up @@ -38,7 +39,14 @@ if (argv.help) {
const dir = resolve(argv._[0] || '.')

const srv = new Server({ dir })
srv.start(argv.port)

exists(resolve(process.cwd(), '.next')).then(exists => {
Copy link
Contributor

@arunoda arunoda Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be dir not process.cwd()

if (!exists) {
console.error(`> Error! The application should be compiled with \`next build\` first.`)
Copy link
Contributor

@arunoda arunoda Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a message like this:

Could not found the '.next' directory! Try building your app with 'next build' before starting the server.

cc @rauchg

process.exit(0)
Copy link
Contributor

@arunoda arunoda Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need exit with a non-zero code.

}
srv.start(argv.port)
})
.then(() => {
if (!process.env.NOW) {
console.log(`> Ready on http://localhost:${argv.port}`)
Expand All @@ -48,3 +56,4 @@ srv.start(argv.port)
console.error(err)
process.exit(1)
})

Loading