Skip to content

Conversation

@ehtb
Copy link

@ehtb ehtb commented Jan 10, 2017

See #722 as well, but I can imagine more use cases.

See vercel#722 as well, but I can imagine more use cases.
@ehtb
Copy link
Author

ehtb commented Jan 11, 2017

Thinking about it, the other options (dev, dir, quiet) should not be overridden, so this change should only involve staticMarkup.

Moving staticMarkup to renderToHTML would also make sense. It could be set on the renderToHTML call since it also appears the setting is only used there.

@timneutkens
Copy link
Member

@ehtb could you have a look at #793 since it involves AMP 👍

@timneutkens
Copy link
Member

Closing in favor of the AMP example. Please re-open if needed ❤️

@timneutkens timneutkens closed this Feb 7, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants