Skip to content

Make sure not to trigger getInitialProps on nav back from hash #7255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2019
Merged

Make sure not to trigger getInitialProps on nav back from hash #7255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/next-server/lib/router/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ export default class Router implements BaseRouter {
// If the url change is only related to a hash change
// We should not proceed. We should only change the state.
if (this.onlyAHashChange(as)) {
this.asPath = as
Router.events.emit('hashChangeStart', as)
this.changeState(method, url, as)
this.scrollToHash(as)
Expand Down
12 changes: 12 additions & 0 deletions test/integration/client-navigation/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,18 @@ describe('Client Navigation', () => {

await browser.close()
})

it('should not run getInitialProps when removing via back', async () => {
const browser = await webdriver(context.appPort, '/nav/hash-changes')

const counter = await browser
.elementByCss('#scroll-to-item-400').click()
.back()
.elementByCss('p').text()

expect(counter).toBe('COUNT: 0')
await browser.close()
})
})

describe('when hash set to empty', () => {
Expand Down