-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make inputs.skipNativeInstall do what it says #69674
Conversation
Failing test suitesCommit: ab8c993
Expand output● app-dir static/dynamic handling › should use auto no cache when no fetch config
● app-dir static/dynamic handling › should use auto no cache when no fetch config
● app-dir static/dynamic handling › should still cache even though the
● app-dir static/dynamic handling › should still cache even though the
● app-dir static/dynamic handling › should warn for too many cache tags
● app-dir static/dynamic handling › should warn for too many cache tags
● app-dir static/dynamic handling › should propagate unstable_cache tags correctly
● app-dir static/dynamic handling › should propagate unstable_cache tags correctly
● app-dir static/dynamic handling › should infer a fetchCache of force-no-store when force-dynamic is used
● app-dir static/dynamic handling › should infer a fetchCache of force-no-store when force-dynamic is used
● app-dir static/dynamic handling › force-dynamic should supercede a "default" cache value
● app-dir static/dynamic handling › force-dynamic should supercede a "default" cache value
● app-dir static/dynamic handling › fetchCache config should supercede dynamic config when force-dynamic is used
● app-dir static/dynamic handling › fetchCache config should supercede dynamic config when force-dynamic is used
● app-dir static/dynamic handling › fetch
● app-dir static/dynamic handling › fetch
● app-dir static/dynamic handling › should correctly include headers instance in cache key
● app-dir static/dynamic handling › should correctly include headers instance in cache key
● app-dir static/dynamic handling › should correctly de-dupe fetch without next cache /react-fetch-deduping-node
● app-dir static/dynamic handling › should correctly de-dupe fetch without next cache /react-fetch-deduping-node
● app-dir static/dynamic handling › should correctly de-dupe fetch without next cache /react-fetch-deduping-edge
● app-dir static/dynamic handling › should correctly de-dupe fetch without next cache /react-fetch-deduping-edge
● app-dir static/dynamic handling › unstable-cache should work in pages/unstable-cache-node
● app-dir static/dynamic handling › unstable-cache should work in pages/unstable-cache-node
● app-dir static/dynamic handling › unstable-cache should work in pages/unstable-cache-edge
● app-dir static/dynamic handling › unstable-cache should work in pages/unstable-cache-edge
● app-dir static/dynamic handling › unstable-cache should work in pages/api/unstable-cache-node
● app-dir static/dynamic handling › unstable-cache should work in pages/api/unstable-cache-node
● app-dir static/dynamic handling › unstable-cache should work in pages/api/unstable-cache-edge
● app-dir static/dynamic handling › unstable-cache should work in pages/api/unstable-cache-edge
● app-dir static/dynamic handling › should not have cache tags header for non-minimal mode
● app-dir static/dynamic handling › should not have cache tags header for non-minimal mode
● app-dir static/dynamic handling › should correctly skip caching POST fetch for POST handler
● app-dir static/dynamic handling › should correctly skip caching POST fetch for POST handler
● app-dir static/dynamic handling › should correctly handle fetchCache = "force-no-store"
● app-dir static/dynamic handling › should correctly handle fetchCache = "force-no-store"
● app-dir static/dynamic handling › should not cache non-ok statusCode
● app-dir static/dynamic handling › should not cache non-ok statusCode
● app-dir static/dynamic handling › should output HTML/RSC files for static paths
● app-dir static/dynamic handling › should output HTML/RSC files for static paths
● app-dir static/dynamic handling › should have correct prerender-manifest entries
● app-dir static/dynamic handling › should have correct prerender-manifest entries
● app-dir static/dynamic handling › should output debug info for static bailouts
● app-dir static/dynamic handling › should output debug info for static bailouts
● app-dir static/dynamic handling › should log fetch metrics to the diagnostics directory
● app-dir static/dynamic handling › should log fetch metrics to the diagnostics directory
● app-dir static/dynamic handling › should stream properly for /stale-cache-serving/app-page
● app-dir static/dynamic handling › should stream properly for /stale-cache-serving/app-page
● app-dir static/dynamic handling › should stream properly for /stale-cache-serving/route-handler
● app-dir static/dynamic handling › should stream properly for /stale-cache-serving/route-handler
● app-dir static/dynamic handling › should stream properly for /stale-cache-serving-edge/app-page
● app-dir static/dynamic handling › should stream properly for /stale-cache-serving-edge/app-page
● app-dir static/dynamic handling › should stream properly for /stale-cache-serving-edge/route-handler
● app-dir static/dynamic handling › should stream properly for /stale-cache-serving-edge/route-handler
● app-dir static/dynamic handling › should correctly handle statusCode with notFound + ISR
● app-dir static/dynamic handling › should correctly handle statusCode with notFound + ISR
● app-dir static/dynamic handling › should cache correctly for fetchCache = default-cache
● app-dir static/dynamic handling › should cache correctly for fetchCache = default-cache
● app-dir static/dynamic handling › should cache correctly when accessing search params opts into dynamic rendering
● app-dir static/dynamic handling › should cache correctly when accessing search params opts into dynamic rendering
● app-dir static/dynamic handling › should cache correctly for fetchCache = force-cache
● app-dir static/dynamic handling › should cache correctly for fetchCache = force-cache
● app-dir static/dynamic handling › should cache correctly for cache: no-store
● app-dir static/dynamic handling › should cache correctly for cache: no-store
● app-dir static/dynamic handling › should not error with dynamic server usage with force-static
● app-dir static/dynamic handling › should not error with dynamic server usage with force-static
● app-dir static/dynamic handling › should produce response with url from fetch
● app-dir static/dynamic handling › should produce response with url from fetch
● app-dir static/dynamic handling › should properly error when dynamic = "error" page uses dynamic
● app-dir static/dynamic handling › should properly error when dynamic = "error" page uses dynamic
● app-dir static/dynamic handling › should skip cache in draft mode
● app-dir static/dynamic handling › should skip cache in draft mode
● app-dir static/dynamic handling › should handle partial-gen-params with default dynamicParams correctly
● app-dir static/dynamic handling › should handle partial-gen-params with default dynamicParams correctly
● app-dir static/dynamic handling › should handle partial-gen-params with layout dynamicParams = false correctly
● app-dir static/dynamic handling › should handle partial-gen-params with layout dynamicParams = false correctly
● app-dir static/dynamic handling › should handle partial-gen-params with page dynamicParams = false correctly
● app-dir static/dynamic handling › should handle partial-gen-params with page dynamicParams = false correctly
● app-dir static/dynamic handling › should honor fetch cache correctly
● app-dir static/dynamic handling › should honor fetch cache correctly
● app-dir static/dynamic handling › should honor fetch cache correctly (edge)
● app-dir static/dynamic handling › should honor fetch cache correctly (edge)
● app-dir static/dynamic handling › should cache correctly with authorization header and revalidate
● app-dir static/dynamic handling › should cache correctly with authorization header and revalidate
● app-dir static/dynamic handling › should skip fetch cache when an authorization header is present after dynamic usage
● app-dir static/dynamic handling › should skip fetch cache when an authorization header is present after dynamic usage
● app-dir static/dynamic handling › should skip fetch cache when accessing request properties
● app-dir static/dynamic handling › should skip fetch cache when accessing request properties
● app-dir static/dynamic handling › should not cache correctly with POST method request init
● app-dir static/dynamic handling › should not cache correctly with POST method request init
● app-dir static/dynamic handling › should cache correctly with post method and revalidate
● app-dir static/dynamic handling › should cache correctly with post method and revalidate
● app-dir static/dynamic handling › should cache correctly with post method and revalidate edge
● app-dir static/dynamic handling › should cache correctly with post method and revalidate edge
● app-dir static/dynamic handling › should cache correctly with POST method and revalidate
● app-dir static/dynamic handling › should cache correctly with POST method and revalidate
● app-dir static/dynamic handling › should cache correctly with cookie header and revalidate
● app-dir static/dynamic handling › should cache correctly with cookie header and revalidate
● app-dir static/dynamic handling › should cache correctly with utf8 encoding
● app-dir static/dynamic handling › should cache correctly with utf8 encoding
● app-dir static/dynamic handling › should cache correctly with utf8 encoding edge
● app-dir static/dynamic handling › should cache correctly with utf8 encoding edge
● app-dir static/dynamic handling › should cache correctly handle JSON body
● app-dir static/dynamic handling › should cache correctly handle JSON body
● app-dir static/dynamic handling › should not throw Dynamic Server Usage error when using generateStaticParams with draftMode
● app-dir static/dynamic handling › should not throw Dynamic Server Usage error when using generateStaticParams with draftMode
● app-dir static/dynamic handling › should force SSR correctly for headers usage
● app-dir static/dynamic handling › should force SSR correctly for headers usage
● app-dir static/dynamic handling › should allow dynamic routes to access cookies
● app-dir static/dynamic handling › should allow dynamic routes to access cookies
● app-dir static/dynamic handling › should not error with generateStaticParams and dynamic data
● app-dir static/dynamic handling › should not error with generateStaticParams and dynamic data
● app-dir static/dynamic handling › should not error with force-dynamic and catch-all routes
● app-dir static/dynamic handling › should not error with force-dynamic and catch-all routes
● app-dir static/dynamic handling › should not error with generateStaticParams and authed data on revalidate
● app-dir static/dynamic handling › should not error with generateStaticParams and authed data on revalidate
● app-dir static/dynamic handling › should work with forced dynamic path
● app-dir static/dynamic handling › should work with forced dynamic path
● app-dir static/dynamic handling › should work with dynamic path no generateStaticParams
● app-dir static/dynamic handling › should work with dynamic path no generateStaticParams
● app-dir static/dynamic handling › should handle dynamicParams: true correctly
● app-dir static/dynamic handling › should handle dynamicParams: true correctly
● app-dir static/dynamic handling › should ssr dynamically when detected automatically with fetch cache option
● app-dir static/dynamic handling › should ssr dynamically when detected automatically with fetch cache option
● app-dir static/dynamic handling › should render not found pages correctly and fallback to the default one
● app-dir static/dynamic handling › should render not found pages correctly and fallback to the default one
● app-dir static/dynamic handling › should ssr dynamically when detected automatically with fetch revalidate option
● app-dir static/dynamic handling › should ssr dynamically when detected automatically with fetch revalidate option
● app-dir static/dynamic handling › should ssr dynamically when forced via config
● app-dir static/dynamic handling › should ssr dynamically when forced via config
● app-dir static/dynamic handling › useSearchParams › client › should bailout to client rendering - with suspense boundary
● app-dir static/dynamic handling › useSearchParams › client › should bailout to client rendering - with suspense boundary
● app-dir static/dynamic handling › useSearchParams › client › should have empty search params on force-static
● app-dir static/dynamic handling › useSearchParams › client › should have empty search params on force-static
● app-dir static/dynamic handling › useSearchParams › client › should have values from canonical url on rewrite
● app-dir static/dynamic handling › useSearchParams › client › should have values from canonical url on rewrite
● app-dir static/dynamic handling › useSearchParams › server response › should bailout to client rendering - with suspense boundary
● app-dir static/dynamic handling › useSearchParams › server response › should bailout to client rendering - with suspense boundary
● app-dir static/dynamic handling › useSearchParams › server response › should have empty search params on force-static
● app-dir static/dynamic handling › useSearchParams › server response › should have empty search params on force-static
● app-dir static/dynamic handling › usePathname › should have the correct values
● app-dir static/dynamic handling › usePathname › should have the correct values
● app-dir static/dynamic handling › usePathname › should have values from canonical url on rewrite
● app-dir static/dynamic handling › usePathname › should have values from canonical url on rewrite
● app-dir static/dynamic handling › unstable_noStore › should opt-out of static optimization
● app-dir static/dynamic handling › unstable_noStore › should opt-out of static optimization
● app-dir static/dynamic handling › unstable_noStore › should not opt-out of static optimization when used in next/cache
● app-dir static/dynamic handling › unstable_noStore › should not opt-out of static optimization when used in next/cache
● app-dir static/dynamic handling › unstable_cache › should retrieve the same value on second request
● app-dir static/dynamic handling › unstable_cache › should retrieve the same value on second request
● app-dir static/dynamic handling › unstable_cache › should bypass cache in draft mode
● app-dir static/dynamic handling › unstable_cache › should bypass cache in draft mode
● app-dir static/dynamic handling › unstable_cache › should not cache new result in draft mode
● app-dir static/dynamic handling › unstable_cache › should not cache new result in draft mode
● app-dir static/dynamic handling › unstable_cache › should not error when retrieving the value undefined
● app-dir static/dynamic handling › unstable_cache › should not error when retrieving the value undefined
● app-dir static/dynamic handling › unstable_cache › should not error when calling a fetch no-store
● app-dir static/dynamic handling › unstable_cache › should not error when calling a fetch no-store
● app-dir static/dynamic handling › unstable_cache › should not error when calling a fetch no-cache
● app-dir static/dynamic handling › unstable_cache › should not error when calling a fetch no-cache
● app-dir static/dynamic handling › should keep querystring on static page
● app-dir static/dynamic handling › should keep querystring on static page
● app-dir static/dynamic handling › should have logs from cache-handler
● app-dir static/dynamic handling › should have logs from cache-handler
● app-dir static/dynamic handling › Incremental cache limits › should cache large data when using custom cache handler and force-cache mode
● app-dir static/dynamic handling › Incremental cache limits › should cache large data when using custom cache handler and force-cache mode
● app-dir static/dynamic handling › should build dynamic param with edge runtime correctly
● app-dir static/dynamic handling › should build dynamic param with edge runtime correctly
● Test suite failed to run
Read more about building and testing Next.js in contributing.md. |
...instead of doing the opposite before this PR: - `skipNativeInstall: 'yes'` sets `NEXT_SKIP_NATIVE_POSTINSTALL=''` - `skipNativeInstall: 'no'` sets `NEXT_SKIP_NATIVE_POSTINSTALL=true` after this PR: - `skipNativeInstall: 'yes'` sets `NEXT_SKIP_NATIVE_POSTINSTALL='1'` - `skipNativeInstall: 'no'` sets `NEXT_SKIP_NATIVE_POSTINSTALL=''`
...instead of doing the opposite before this PR: - `skipNativeInstall: 'yes'` sets `NEXT_SKIP_NATIVE_POSTINSTALL=''` - `skipNativeInstall: 'no'` sets `NEXT_SKIP_NATIVE_POSTINSTALL=true` after this PR: - `skipNativeInstall: 'yes'` sets `NEXT_SKIP_NATIVE_POSTINSTALL='1'` - `skipNativeInstall: 'no'` sets `NEXT_SKIP_NATIVE_POSTINSTALL=''`
...instead of doing the opposite
before this PR:
skipNativeInstall: 'yes'
setsNEXT_SKIP_NATIVE_POSTINSTALL=''
skipNativeInstall: 'no'
setsNEXT_SKIP_NATIVE_POSTINSTALL=true
after this PR:
skipNativeInstall: 'yes'
setsNEXT_SKIP_NATIVE_POSTINSTALL='1'
skipNativeInstall: 'no'
setsNEXT_SKIP_NATIVE_POSTINSTALL=''