Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] remove exceeding cells #69059

Closed
wants to merge 49 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
9d1592f
add new backend
sokra Jul 26, 2024
023f16e
new backend
sokra Jul 29, 2024
32b447a
add more backend method implementations
sokra Aug 2, 2024
fcea2fd
very basic operation working
sokra Aug 7, 2024
c6f4e70
add own cells reading
sokra Aug 7, 2024
db0bc43
call transient tasks
sokra Aug 7, 2024
ca6cbb4
call persistent tasks
sokra Aug 7, 2024
da0f04c
run tests multiple times to test caching
sokra Aug 7, 2024
41d716c
add cell/output reading and creating cached tasks
sokra Aug 7, 2024
f573143
serialization fixup
sokra Aug 9, 2024
5029e1c
remove unused stuff
sokra Aug 9, 2024
ed8b087
clippy
sokra Aug 9, 2024
2fb17f3
remove things not yet used (persistence)
sokra Aug 9, 2024
0d8a666
clippy
sokra Aug 9, 2024
37df4cc
add more tests for new backend
sokra Aug 9, 2024
eb0b6c9
add support for connect_child
sokra Aug 13, 2024
78af7a5
set root type on root tasks
sokra Aug 9, 2024
ffc9e21
remove old edges when task recomputation completes
sokra Aug 12, 2024
c448018
add try_get_function_id
sokra Aug 14, 2024
b0977cb
Revert "remove things not yet used (persistence)"
sokra Aug 9, 2024
dd40246
add lmdb persisting and restoring
sokra Aug 8, 2024
bdec3c3
pass test name to test_config to construct db name
sokra Aug 9, 2024
2cce8d9
continue uncompleted operations
sokra Aug 9, 2024
d3fcc67
create dir and logging
sokra Aug 12, 2024
024c2f1
improve error messages
sokra Aug 13, 2024
95e3f2c
handle keys larger than 511 bytes
sokra Aug 13, 2024
6dac853
set root type on root tasks
sokra Aug 9, 2024
4d5b42e
move backend impl into type alias
sokra Aug 12, 2024
733d42a
add new backend feature
sokra Aug 12, 2024
c736b0d
add missing import
sokra Aug 14, 2024
36b118c
initial aggregation update
sokra Aug 13, 2024
03abe58
enable new backend
sokra Aug 13, 2024
686c198
WIP: remove todos
sokra Aug 13, 2024
e126a75
more aggregation operations
sokra Aug 13, 2024
bc62ead
handle state serialization
sokra Aug 14, 2024
aa5ec04
validate serialization and improve errors
sokra Aug 14, 2024
c39ec7d
avoid some serde skip and untagged
sokra Aug 14, 2024
40aab63
use TransientState
sokra Aug 14, 2024
1aa5572
validate serialization and improve errors
sokra Aug 14, 2024
4835ae1
store project options in state
sokra Aug 14, 2024
44e902a
show lookup error
sokra Aug 14, 2024
d4f7561
log restored db entries
sokra Aug 14, 2024
26b7652
improve error
sokra Aug 14, 2024
2a0dd5a
improve benchmark_file_io for persistent cache
sokra Aug 14, 2024
4866761
WIP: print new tasks
sokra Aug 14, 2024
6db46f3
gracefully stop turbo-tasks to allow persisting to complete
sokra Aug 14, 2024
a96143d
avoid storing transient tasks
sokra Aug 14, 2024
92aff18
WIP: logging
sokra Aug 14, 2024
15950e6
remove exceeding cells
sokra Aug 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use TransientState
  • Loading branch information
sokra committed Sep 4, 2024
commit 40aab6335806083c1b2ebed077f7a69a899c0507
6 changes: 2 additions & 4 deletions turbopack/crates/turbopack-ecmascript/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,7 @@ pub struct EcmascriptModuleAsset {
pub compile_time_info: Vc<CompileTimeInfo>,
pub inner_assets: Option<Vc<InnerAssets>>,
#[turbo_tasks(debug_ignore)]
#[serde(skip)]
last_successful_parse: turbo_tasks::State<Option<ReadRef<ParseResult>>>,
last_successful_parse: turbo_tasks::TransientState<ReadRef<ParseResult>>,
}

#[turbo_tasks::value_trait]
Expand Down Expand Up @@ -341,8 +340,7 @@ impl EcmascriptParsable for EcmascriptModuleAsset {
let real_result_value = real_result.await?;
let this = self.await?;
let result_value = if matches!(*real_result_value, ParseResult::Ok { .. }) {
this.last_successful_parse
.set(Some(real_result_value.clone()));
this.last_successful_parse.set(real_result_value.clone());
real_result_value
} else {
let state_ref = this.last_successful_parse.get();
Expand Down