Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when preview builds were not found in deploy tests #68589

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Improve error message when preview builds were not found in deploy tests #68589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scripts/test-new-tests.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,13 @@ async function main() {
)
await new Promise((resolve) => setTimeout(resolve, timeout))
} else {
if (res.status === 404) {
throw new Error(
`Artifacts not found for commit ${commitSha}. ` +
`This can happen if the preview builds either failed or didn't succeed yet. ` +
`Once the "Deploy Preview tarball" job has finished, a retry should fix this error.`
)
}
throw new Error(
`Failed to verify artifacts for commit ${commitSha}: ${res.status}`
)
Expand Down
Loading