Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #68228 Clarify width and height properties in Image component docs #68248

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

Tim-Zj
Copy link
Contributor

@Tim-Zj Tim-Zj commented Jul 28, 2024

Clarify width and height properties in Image component docs

This PR updates the documentation for the width and height properties of the Image component to clarify that these attributes represent the intrinsic dimensions of the image and do not determine the rendered size, which is controlled by CSS. This clarification aligns the documentation with the behavior of the HTML <img> tag.

Fixes issue #68228.
Closes #68228

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jul 28, 2024
@ijjk
Copy link
Member

ijjk commented Jul 28, 2024

Allow CI Workflow Run

  • approve CI run for commit: e85bbf8

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Jul 28, 2024

Allow CI Workflow Run

  • approve CI run for commit: e85bbf8

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Jul 28, 2024

Allow CI Workflow Run

  • approve CI run for commit: e85bbf8

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Tim-Zj Tim-Zj requested a review from Willem-Jaap July 30, 2024 01:33
@Tim-Zj Tim-Zj changed the title Clarify width and height properties in Image component docs Closes #68228 Clarify width and height properties in Image component docs Jul 30, 2024
@Tim-Zj Tim-Zj changed the title Closes #68228 Clarify width and height properties in Image component docs fixes #68228 Clarify width and height properties in Image component docs Jul 30, 2024
Co-authored-by: Willem-Jaap <67187467+Willem-Jaap@users.noreply.github.com>
# Conflicts:
#	docs/02-app/02-api-reference/01-components/image.mdx
@ijjk ijjk enabled auto-merge (squash) September 16, 2024 20:26
@ijjk ijjk merged commit aa66ee4 into vercel:canary Sep 16, 2024
38 checks passed
@github-actions github-actions bot added the locked label Oct 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Clarity on the width and height properties of the Image component
3 participants