Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test assertions #65319

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 3, 2024

Similar to #65285 but this time replacing expect(array.every(fn)) with expect(array).toEqual(expect.toSatisfyAll(fn))

Example error message:

Expected: toSatisfyAll<(item)=>files.some((file)=>item.test(file))>
    Received: [/webpack-runtime\.js/, /node_modules\/react\/index\.js/, /node_modules\/react\/package\.json/, /node_modules\/react\/cjs\/react\.production\.min\.js/]

    Files:
    ../../../node_modules/.pnpm/file+..+next-repo-5b034bd6b78c2033850d0e1023acbd1ab12119a7393ab39760ba15867e730958+packages+n_mklgnekaf5rcxiuphg5rfolud4/node_modules/next/dist/pages/_app.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/cjs/react-jsx-runtime.development.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/cjs/react-jsx-runtime.production.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/cjs/react.development.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/cjs/react.production.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/index.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/jsx-runtime.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/package.json
    ../../../node_modules/react
    ../../../package.json
    ../../package.json
    ../webpack-runtime.js

Made it easier to spot that this is just an outdated Regex in #65058 since minified bundles were removed.

Closes NEXT-3310

Example error message:

```
Expected: toSatisfyAll<(item)=>files.some((file)=>item.test(file))>
    Received: [/webpack-runtime\.js/, /node_modules\/react\/index\.js/, /node_modules\/react\/package\.json/, /node_modules\/react\/cjs\/react\.production\.min\.js/]

    Files:
    ../../../node_modules/.pnpm/file+..+next-repo-5b034bd6b78c2033850d0e1023acbd1ab12119a7393ab39760ba15867e730958+packages+n_mklgnekaf5rcxiuphg5rfolud4/node_modules/next/dist/pages/_app.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/cjs/react-jsx-runtime.development.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/cjs/react-jsx-runtime.production.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/cjs/react.development.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/cjs/react.production.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/index.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/jsx-runtime.js
    ../../../node_modules/.pnpm/react@19.0.0-beta-4508873393-20240430/node_modules/react/package.json
    ../../../node_modules/react
    ../../../package.json
    ../../package.json
    ../webpack-runtime.js
```
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels May 3, 2024
@ijjk
Copy link
Member

ijjk commented May 3, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented May 3, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
buildDuration 15.5s 14.1s N/A
buildDurationCached 8.1s 7.3s N/A
nodeModulesSize 360 MB 360 MB
nextStartRea..uration (ms) 407ms 413ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
1103-HASH.js gzip 31.9 kB 31.9 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.05 kB 5.05 kB
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 231 B 228 B N/A
main-HASH.js gzip 31.6 kB 31.6 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 50.4 kB 50.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.27 kB 4.27 kB
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 8.27 kB 8.27 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
edge-ssr.js gzip 94.8 kB 94.8 kB N/A
page.js gzip 182 kB 182 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
middleware-b..fest.js gzip 622 B 624 B N/A
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB
edge-runtime..pack.js gzip 839 B 839 B
Overall change 26.7 kB 26.7 kB
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 100 kB 100 kB
app-page-tur..prod.js gzip 94.6 kB 94.6 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93.3 kB 93.3 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.3 kB 15.3 kB
app-route-tu..prod.js gzip 15.3 kB 15.3 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route.ru...dev.js gzip 21.3 kB 21.3 kB
app-route.ru..prod.js gzip 15 kB 15 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.7 kB 51.7 kB
Overall change 964 kB 964 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/better-test-assertions-satisfy Change
0.pack gzip 1.62 MB 1.62 MB N/A
index.pack gzip 113 kB 113 kB ⚠️ +197 B
Overall change 113 kB 113 kB ⚠️ +197 B
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: 277e6c9

@eps1lon eps1lon marked this pull request as ready for review May 3, 2024 11:30
@eps1lon eps1lon merged commit aa1e967 into canary May 6, 2024
80 checks passed
@eps1lon eps1lon deleted the sebbie/better-test-assertions-satisfy branch May 6, 2024 19:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants