Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test-firefox-safari is required for tests passing #63733

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 26, 2024

This can currently fail and still pass our final tests pass check which it shouldn't

x-ref: #63726

Closes NEXT-2939

@ijjk ijjk requested review from a team as code owners March 26, 2024 18:51
@ijjk ijjk requested review from jh3y and delbaoliveira and removed request for a team March 26, 2024 18:51
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Mar 26, 2024
@ijjk ijjk enabled auto-merge (squash) March 26, 2024 18:52
@ijjk
Copy link
Member Author

ijjk commented Mar 26, 2024

Tests Passed

@ijjk
Copy link
Member Author

ijjk commented Mar 26, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
buildDuration 14.3s 14.5s ⚠️ +206ms
buildDurationCached 8.9s 6.8s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 403ms 407ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
2453-HASH.js gzip 31 kB 31 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.61 kB 1.61 kB
Next Runtimes
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.7 kB 98.7 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51 kB 51 kB
Overall change 944 kB 944 kB
build cache Overall increase ⚠️
vercel/next.js canary ijjk/next.js ci/fix-required-safari Change
0.pack gzip 1.57 MB 1.57 MB ⚠️ +107 B
index.pack gzip 106 kB 106 kB ⚠️ +250 B
Overall change 1.68 MB 1.68 MB ⚠️ +357 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 4edc16b

@ijjk ijjk merged commit f762af6 into vercel:canary Mar 26, 2024
71 checks passed
@ijjk ijjk deleted the ci/fix-required-safari branch March 26, 2024 19:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants