-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --ci to jest tests in CI #60432
Merged
Merged
Add --ci to jest tests in CI #60432
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6623826
Add --ci to jest tests in CI
timneutkens 71a4845
Write snapshots
timneutkens 90a1d8d
Use waitFor
timneutkens 0da6450
wait for one second after opening the browser to ensure all files loaded
timneutkens d32ef60
Add missing snapshots
timneutkens a7380f7
Update test to match Turbopack output
timneutkens 9c05295
Update snapshot
timneutkens bdbf8ba
Use check() for flaky test
timneutkens e91e464
Update snapshots
timneutkens 1e6bbab
Fix test
timneutkens 13f87d0
Use retry helper instead
timneutkens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import { getFullUrl } from 'next-test-utils' | ||
import { getFullUrl, waitFor } from 'next-test-utils' | ||
import os from 'os' | ||
import { BrowserInterface } from './browsers/base' | ||
|
||
|
@@ -183,5 +183,12 @@ export default async function webdriver( | |
|
||
console.log(`\n> Hydration complete for ${fullUrl}\n`) | ||
} | ||
|
||
// This is a temporary workaround for turbopack starting watching too late. | ||
// So we delay file changes by 500ms to give it some time | ||
// to connect the WebSocket and start watching. | ||
if (process.env.TURBOPACK) { | ||
await waitFor(1000) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the wait hydration logic above not work properly with turbopack mode or is it just not long enough of a delay alone? |
||
} | ||
return browser | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kinda think it would be cleaner to have just one big if else block, but doesn't matter