Skip to content

Use correct default for query #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2018
Merged

Use correct default for query #5851

merged 2 commits into from
Dec 10, 2018

Conversation

@timneutkens
Copy link
Member

@timneutkens timneutkens commented Dec 10, 2018 •
edited
Loading

Fixes #2943
Fixes #4341

The backwards-compatible version of this fix. It's basically the same as with router.js, where we always know the query will be at least {}

@timneutkens timneutkens requested a review from leo December 10, 2018 21:26
@timneutkens timneutkens merged commit 93424b6 into vercel:canary Dec 10, 2018
@timneutkens timneutkens deleted the fix/router-error branch December 10, 2018 22:40
@lock lock bot locked as resolved and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@leo leo leo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

shallowEquals throws when using custom server and not passing an object for query to app.render

2 participants

@timneutkens @leo