Fix unmatched WebSocket upgrade requests being closed#57245
Merged
kodiakhq[bot] merged 5 commits intocanaryfrom Oct 23, 2023
Merged
Fix unmatched WebSocket upgrade requests being closed#57245kodiakhq[bot] merged 5 commits intocanaryfrom
kodiakhq[bot] merged 5 commits intocanaryfrom
Conversation
Member
Tests Passed |
Member
Stats from current PRDefault BuildGeneral Overall increase
|
| vercel/next.js canary | vercel/next.js shu/e8c2 | Change | |
|---|---|---|---|
| buildDuration | 10.2s | 10.5s | |
| buildDurationCached | 6.1s | 6s | N/A |
| nodeModulesSize | 174 MB | 174 MB | |
| nextStartRea..uration (ms) | 519ms | 510ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js shu/e8c2 | Change | |
|---|---|---|---|
| 199-HASH.js gzip | 27.9 kB | 27.9 kB | N/A |
| 3f784ff6-HASH.js gzip | 53.2 kB | 53.2 kB | N/A |
| 99.HASH.js gzip | 182 B | 182 B | ✓ |
| framework-HASH.js gzip | 45.5 kB | 45.5 kB | ✓ |
| main-app-HASH.js gzip | 254 B | 252 B | N/A |
| main-HASH.js gzip | 33 kB | 33 kB | N/A |
| webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
| Overall change | 45.7 kB | 45.7 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js shu/e8c2 | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js shu/e8c2 | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 206 B | 205 B | N/A |
| _error-HASH.js gzip | 182 B | 180 B | N/A |
| amp-HASH.js gzip | 506 B | 505 B | N/A |
| css-HASH.js gzip | 322 B | 323 B | N/A |
| dynamic-HASH.js gzip | 2.59 kB | 2.59 kB | ✓ |
| edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 369 B | 369 B | ✓ |
| image-HASH.js gzip | 4.38 kB | 4.38 kB | N/A |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
| routerDirect..HASH.js gzip | 316 B | 318 B | N/A |
| script-HASH.js gzip | 385 B | 384 B | N/A |
| withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 3.99 kB | 3.99 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js shu/e8c2 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 484 B | 482 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js shu/e8c2 | Change | |
|---|---|---|---|
| index.html gzip | 528 B | 529 B | N/A |
| link.html gzip | 541 B | 541 B | ✓ |
| withRouter.html gzip | 523 B | 524 B | N/A |
| Overall change | 541 B | 541 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js shu/e8c2 | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 95.8 kB | 95.8 kB | ✓ |
| page.js gzip | 158 kB | 158 kB | N/A |
| Overall change | 95.8 kB | 95.8 kB | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js shu/e8c2 | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 625 B | 624 B | N/A |
| middleware-r..fest.js gzip | 150 B | 151 B | N/A |
| middleware.js gzip | 22.9 kB | 22.9 kB | N/A |
| edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
| Overall change | 1.92 kB | 1.92 kB | ✓ |
timneutkens
approved these changes
Oct 23, 2023
huozhi
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not close unmatched sockets as it might be handled by user's server.
Fixes #56996
Fixes #49334
Fixes #55299