Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#53190): add missing crossOrigin to assetsPrefix resources #56311

Merged
merged 8 commits into from
Oct 2, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
huozhi committed Oct 2, 2023
commit a344c2db634b51c4c8ac66c0c3660ab037a0d925
7 changes: 5 additions & 2 deletions test/e2e/app-dir/app-config-crossorigin/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ createNextDescribe(
{
files: __dirname,
skipDeployment: true,
skipStart: true,
},
({ next }) => {
({ next, isNextStart }) => {
if (isNextStart) {
it('skip in start mode', () => {})
return
}
it('should render correctly with assetPrefix: "/"', async () => {
const $ = await next.render$('/')
// Only potential external (assetPrefix) <script /> and <link /> should have crossorigin attribute
Expand Down
Loading