Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runner labels for PR stats #54524

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Update runner labels for PR stats #54524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ffd083
Update runner labels for PR stats
ijjk Aug 24, 2023
ca8d8ca
ensure checkout
ijjk Aug 24, 2023
9cfbb53
Merge branch 'canary' into update/pr-stats-runner
ijjk Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions .github/workflows/build_and_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,21 +504,16 @@ jobs:

releaseStats:
name: Release Stats
runs-on: ubuntu-latest
runs-on:
- 'self-hosted'
- 'linux'
- 'x64'
- 'metal'
needs: [publishRelease]
steps:
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_LTS_VERSION }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we don't want to set a specific version of node?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might break if we use latest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's controlled by the next-stats-action step instead of at the top level since we don't need to build until the action runs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next.js/.github/actions/next-stats-action/Dockerfile

Lines 12 to 13 in e471a46

RUN curl -sfLS https://install-node.vercel.app/v18.16.1 | bash -s -- -f
RUN corepack enable

check-latest: true

- uses: actions/cache@v3
timeout-minutes: 5
id: restore-build
- uses: actions/checkout@v3
with:
path: ./*
key: ${{ github.sha }}-${{ github.run_number }}
fetch-depth: 25

- uses: actions/download-artifact@v3
with:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/pull_request_stats.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ jobs:
stats:
name: PR Stats
needs: build
runs-on: ubuntu-latest
runs-on:
- 'self-hosted'
- 'linux'
- 'x64'
- 'metal'
steps:
- uses: actions/checkout@v3
with:
Expand Down
Loading