Add basic HTTPS support for dev only #53926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-carroll
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
ztanner
as code owners
1 task
|
Yes, this would be great to have! Especially, now that dev mode stopped working in recent version of Next.js. Pretty annoying that it won't compile code when you visit a page/path. One of the main reason to use a custom server and in the past OpenTelemetry but that can be resolved with the instrumentation hook and custom instrumentation. |
|
#54016 seems like nextjs team started solving this too |
|
Closing in favor of #54016 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add basic HTTPS/TLS support for dev server only.
Why?
For anyone using the Web Crypto API, a secure browser context is required even in dev.
The latest version of Next.js does not support Hot Module Reload if you are using a custom server: #51162
How?
Add a basic
--httpsflag with the option of specifying a cert & key via the command line or environment variable.NOTE: This only adds support for the Node dev server. It does not add https/tls support for Turbopack
NOTE: This does not address any of the underlying issues associate with #51162, it simply removes a use case for needing a custom server.