Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 02-dynamic-routes.mdx #52975

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Update 02-dynamic-routes.mdx #52975

merged 3 commits into from
Jul 21, 2023

Conversation

Heidar-An
Copy link
Contributor

grammatical mistake

What?

Small grammatical mistake on https://nextjs.org/docs/pages/building-your-application/routing/dynamic-routes

grammatical mistake
@Heidar-An
Copy link
Contributor Author

Heidar-An commented Jul 21, 2023

what does this check failure mean?
(how can I fix it)

@ijjk
Copy link
Member

ijjk commented Jul 21, 2023

Allow CI Workflow Run

  • approve CI run for commit: 75aa43a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Heidar-An
Copy link
Contributor Author

why are these tests all failing?

@ztanner
Copy link
Member

ztanner commented Jul 21, 2023

@Heidar-An no worries, nothing you need to fix! Thank you for the PR

@kodiakhq kodiakhq bot merged commit 732219e into vercel:canary Jul 21, 2023
45 of 46 checks passed
@Heidar-An Heidar-An deleted the patch-1 branch July 21, 2023 17:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants