Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msic: disable otel esm test #52325

Merged
merged 3 commits into from
Jul 6, 2023
Merged

msic: disable otel esm test #52325

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5ef4ca
disable test
feedthejim Jul 6, 2023
64182f0
Update test/e2e/instrumentation-hook/instrumentation-hook.test.ts
huozhi Jul 6, 2023
146a5a9
lint
feedthejim Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 27 additions & 25 deletions test/e2e/instrumentation-hook/instrumentation-hook.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,31 +21,33 @@ const describeCase = (
)
}
describe('Instrumentation Hook', () => {
createNextDescribe(
'with-esm-import',
{
files: path.join(__dirname, 'with-esm-import'),
nextConfig: {
experimental: {
instrumentationHook: true,
},
},
dependencies: {
// This test is mostly for compatibility with this package
'@vercel/otel': 'latest',
},
skipDeployment: true,
},
({ next }) => {
it('with-esm-import should run the instrumentation hook', async () => {
await next.render('/')
await check(
() => next.cliOutput,
/register in instrumentation\.js is running/
)
})
}
)
// TODO: investigate the failure with esm import
// createNextDescribe(
huozhi marked this conversation as resolved.
Show resolved Hide resolved
// 'with-esm-import',
// {
// files: path.join(__dirname, 'with-esm-import'),
// nextConfig: {
// experimental: {
// instrumentationHook: true,
// },
// },
// dependencies: {
// // This test is mostly for compatibility with this package
// '@vercel/otel': 'latest',
// },
// skipDeployment: true,
// },
// ({ next }) => {
// eslint-disable-next-line jest/no-commented-out-tests
// it('with-esm-import should run the instrumentation hook', async () => {
// await next.render('/')
// await check(
// () => next.cliOutput,
// /register in instrumentation\.js is running/
// )
// })
// }
// )

describeCase('with-middleware', ({ next }) => {
it('with-middleware should run the instrumentation hook', async () => {
Expand Down