Skip to content

Make sure react always ends up in the commons bundle #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2018
Merged

Make sure react always ends up in the commons bundle #5192

merged 1 commit into from
Sep 17, 2018

Conversation

@timneutkens
Copy link
Member

@timneutkens timneutkens commented Sep 17, 2018 •
edited
Loading

Fixes an edge case where some library imports react-dom by itself, like react-spring.

@timneutkens timneutkens merged commit 10a9178 into vercel:canary Sep 17, 2018
@timneutkens timneutkens deleted the fix/react-dom-react-commons branch September 17, 2018 13:57
@lock lock bot locked as resolved and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shuding shuding shuding approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timneutkens @shuding