Trigger page register when module is executed #5115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves inconsistent loading issues when one bundle is loaded faster than the other
Member
Author
|
@timneutkens When are you planning to merge this? Is it imminent? Just wondering because I really need this fix and would prefer not to use my fork. |
HaNdTriX
approved these changes
Sep 11, 2018
Member
Author
|
Basically today, was just waiting for Someone to review which has been done now. |
HaNdTriX
reviewed
Sep 11, 2018
| `__NEXT_REGISTER_PAGE('${routeName}', function() {\n`, | ||
| moduleSourcePostModule, | ||
| '\nreturn { page: module.exports.default }', | ||
| '});' |
Contributor
There was a problem hiding this comment.
We might want to remove the linebreaks here or make them consistent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves inconsistent loading issues when one bundle is loaded faster than the other
Fixes vercel/next-plugins#244
Fixes #4997
Fixes #4620