-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Upgrade with-redux example to app router #49994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade with-redux example to app router #49994
Conversation
|
Hi, @leerob @steven-tey It seems that Github Actions CI got broken at Socket Security: Pull Request Alerts and it blocks CI pipeline to advance. This happens for multiple PR's related to examples directory. I've created an issue for that. |
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again. Bot CommandsTo ignore an alert, reply with a comment starting with
📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: @testing-library/user-event@13.5.0, ts-jest@27.1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to simplify this example. Remote saas, remove testing, and focus specifically on Next.js + Redux only in the most minimal, yet complete, example.
|
Sounds like a good idea, I'll simplify it. |
… required by jest
|
@leerob I've removed tests and sass, see if all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop src as well, to match other examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add barrel files (index.ts files that are just re-exports), feels like adding complexity instead of reducing it.
|
@balazsorban44 removed |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
What?
Update with-redux example.
Why?
with-redux example have:
Since app router is stable now and is recommended to use, I've updated this example.
How?
An update includes: