Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @testing-library/react in with-redux example #46085

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

vasucp1207
Copy link
Contributor

Updating the @testing-library/react as the older one is not compatible with react-18.
Screenshot 2023-02-18 at 12 26 55 PM

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Feb 18, 2023
@socket-security
Copy link

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Powered by socket.dev

@ijjk ijjk merged commit f9346f1 into vercel:canary Feb 18, 2023
0xadada added a commit to 0xadada/next.js that referenced this pull request Feb 18, 2023
….com:0xadada/next.js into decrease-time-spent-detecting-path-conflicts

* 'decrease-time-spent-detecting-path-conflicts' of github.com:0xadada/next.js:
  Fix flaky invalid import test (vercel#46089)
  v13.1.7-canary.20
  Update @testing-library/react in with-redux example (vercel#46085)
  Add `vary` header to responses from pages and Edge SSR (vercel#46073)
  Update next/font/google data (vercel#46040)
  Fix adding-exmaples.md doc (vercel#46051)
  Fix next/font error parsing on windows (vercel#46053)
  Add `loader-runner` to compiled packages (vercel#45962)
  Fix export conditions in Webpack config (vercel#46066)
  Check for windows paths in server matchers (vercel#46055)
  Fix failed cache restoring (vercel#46083)
  fix: codemod `next/image` within monorepo (vercel#46047)
  v13.1.7-canary.19
  Remove built files chown
  Revert part of vercel#45971 (vercel#46071)
  Disable cache built files step
  Fix cache built files step (vercel#46075)
@vasucp1207 vasucp1207 deleted the ex-redux branch February 22, 2023 02:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants