Migrate set-output usage to $GITHB_OUTPUT #44757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
requested review from
timneutkens,
shuding,
styfle,
huozhi,
padmaia and
balazsorban44
as code owners
styfle
reviewed
Jan 10, 2023
| @@ -506,7 +506,7 @@ jobs: | |||
| name: next-swc-test-binary | |||
| path: packages/next-swc/native | |||
|
|
|||
| - run: echo "::set-output name=CNA_CHANGE::$(node scripts/run-for-change.js --type cna --always-canary --exec echo 'yup')" | |||
| - run: echo "CNA_CHANGE<<EOF" >> $GITHUB_OUTPUT; echo "$(node scripts/run-for-change.js --type cna --always-canary --exec echo 'yup')" >> $GITHUB_OUTPUT; echo "EOF" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
Did you intend to have two EOF here?
There was a problem hiding this comment.
Two as in the beginning one and end one?
There was a problem hiding this comment.
Yeah. I guess I dont understand how the new format works for newlines like this
There was a problem hiding this comment.
Oh followed this tip to resolve the new line handling https://stackoverflow.com/a/74256214
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/