[docs] Add precision about pageExtensions
#40016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
requested review from
balazsorban44,
huozhi,
ijjk,
leerob,
padmaia,
shuding,
styfle and
timneutkens
as code owners
ijjk
reviewed
Aug 28, 2022
Member
ijjk
left a comment
ijjk
left a comment
There was a problem hiding this comment.
Hi, I'm not sure we need to document this here as we already explain this under the pageExtensions doc here https://nextjs.org/docs/api-reference/next.config.js/custom-page-extensions
Contributor
Author
|
@ijjk ah! I totally missed it. I added the middleware way after I touched I'm fine closing this, it's just that I figured, if it happened to me, might happen to others. |
ijjk
reviewed
Aug 28, 2022
ijjk
approved these changes
Aug 28, 2022
Member
ijjk
left a comment
ijjk
left a comment
There was a problem hiding this comment.
Sounds good to add this note, updated to link to the existing pageExtensions doc. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a precision because when you change the
pageExtensionsconfiguration innext.config.js,middleware.tsisn't recognized anymore.Took me some time to debug this one, not sure if it should be considered a bug or just lack of documentation.
I'll let you be the judge of that.
Documentation / Examples
pnpm lint