Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Fragments in Head #3502

Merged
merged 5 commits into from
Dec 28, 2017
Merged

Add support for Fragments in Head #3502

merged 5 commits into from
Dec 28, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Dec 26, 2017

This PR adds support for React Fragments (16.2.0) in <Head />.

Fixes #3399.

@arunoda
Copy link
Contributor

arunoda commented Dec 26, 2017

Thanks. Can we have a test case for this?

@Sekhmet
Copy link
Contributor Author

Sekhmet commented Dec 26, 2017

Currently canary targets react@16.0.0 - Fragments has been added in 16.2.0. How can I handle this?

@arunoda
Copy link
Contributor

arunoda commented Dec 27, 2017 •
edited
Loading

@Sekhmet you've checked for React.Fragment in this PR changes.
For the devDependencies, update React to the latest.

arunoda
arunoda approved these changes Dec 28, 2017
View reviewed changes
Copy link
Contributor

@arunoda arunoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great.

@arunoda arunoda merged commit 9d059f6 into vercel:canary Dec 28, 2017
@Sekhmet Sekhmet deleted the head-fragments branch December 28, 2017 13:01
@kylealwyn
Copy link

🙏

@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arunoda arunoda arunoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sekhmet @arunoda @kylealwyn