Skip to content

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Dec 17, 2021

It seems the build-native jobs are currently failing with turbo and we will need to investigate this further before enabling it, this disables using turbo for these jobs to allow publishing to continue.

x-ref: #32617
x-ref: vercel/turborepo#326
x-ref: https://github.com/vercel/next.js/runs/4565785923?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/4565785720?check_suite_focus=true
x-ref: https://github.com/vercel/next.js/runs/4565786003?check_suite_focus=true

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 17, 2021
@ijjk ijjk requested a review from styfle December 17, 2021 23:48
styfle
styfle previously approved these changes Dec 17, 2021
shuding
shuding previously approved these changes Dec 17, 2021
@ijjk ijjk dismissed stale reviews from shuding and styfle via c7322c7 December 17, 2021 23:56
@ijjk ijjk requested review from shuding and styfle December 18, 2021 00:13
@ijjk
Copy link
Member Author

ijjk commented Dec 18, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
buildDuration 23.2s 23.2s -19ms
buildDurationCached 4.4s 4.3s -154ms
nodeModulesSize 348 MB 348 MB ⚠️ +7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
/ failed reqs 0 0
/ total time (seconds) 3.801 3.786 -0.02
/ avg req/sec 657.8 660.36 +2.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.995 2.088 ⚠️ +0.09
/error-in-render avg req/sec 1252.99 1197.31 ⚠️ -55.68
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 30.2 kB 30.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
buildDuration 25.1s 25.2s ⚠️ +58ms
buildDurationCached 4.2s 4.3s ⚠️ +95ms
nodeModulesSize 348 MB 348 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
/ failed reqs 0 0
/ total time (seconds) 3.819 3.785 -0.03
/ avg req/sec 654.69 660.57 +5.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.028 2.033 0
/error-in-render avg req/sec 1232.51 1229.95 ⚠️ -2.56
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 30.3 kB 30.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 74.3 kB 74.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js disable/turbo-build-native Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 27e96f8

@ijjk ijjk merged commit f244593 into vercel:canary Dec 18, 2021
@ijjk ijjk deleted the disable/turbo-build-native branch December 18, 2021 01:18
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Next.js team PRs by the Next.js team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants