Skip to content

fix: typescript example supporting strict w/ version >= 4.4 #32023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Octember wants to merge 1 commit into from
Closed

fix: typescript example supporting strict w/ version >= 4.4 #32023

Octember wants to merge 1 commit into from

Conversation

@Octember
Copy link

@Octember Octember commented Dec 2, 2021 •
edited
Loading

fixes #32015

In typescript 4.4, errors were changed to unknown type instead of any. With strict mode enabled, this breaks the with-typescript example as err.message isn't valid.

Thanks! my first PR here 😄

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 2, 2021
ijjk
ijjk reviewed Dec 2, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this also needs to be updated here

next.js/examples/with-typescript/pages/users/[id].tsx

Line 58 in 5747435

} catch (err) {
to resolve the linked issue

balazsorban44
balazsorban44 requested changes Dec 11, 2021
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs an update as well @Octember

next.js/examples/with-typescript/pages/users/[id].tsx

Line 58 in 5747435

} catch (err) {

@balazsorban44 balazsorban44 mentioned this pull request Jan 5, 2022
Closed
@ijjk ijjk mentioned this pull request Jan 5, 2022
Merged
1 task
@kodiakhq kodiakhq bot closed this in #33042 Jan 5, 2022
kodiakhq bot pushed a commit that referenced this pull request Jan 5, 2022
@vicente-s
fix: typescript example supporting strict w/ version >= 4.4 (#33042)
ef7e70e 
## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`

Closes: #32023
Fixes: #32015
@vercel vercel locked as resolved and limited conversation to collaborators Feb 4, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@vicente-s @natew
fix: typescript example supporting strict w/ version >= 4.4 (vercel#3…
f0369ba 
…3042)

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`

Closes: vercel#32023
Fixes: vercel#32015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk left review comments

@balazsorban44 balazsorban44 balazsorban44 requested changes

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GetStaticProps type error using latest TypeScript version with strict option set to true

3 participants

@Octember @balazsorban44 @ijjk