Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc #31639

Merged
merged 5 commits into from
Nov 20, 2021
Merged

Update swc #31639

merged 5 commits into from
Nov 20, 2021

Conversation

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 20, 2021
@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as ready for review November 20, 2021 10:13
@ijjk
Copy link
Member

ijjk commented Nov 20, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-ver-25 Change
buildDuration 23.2s 24.2s ⚠️ +1s
buildDurationCached 4.6s 4.5s -157ms
nodeModulesSize 339 MB 339 MB ⚠️ +15 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-ver-25 Change
/ failed reqs 0 0
/ total time (seconds) 3.863 4.048 ⚠️ +0.19
/ avg req/sec 647.16 617.59 ⚠️ -29.57
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.984 2.1 ⚠️ +0.12
/error-in-render avg req/sec 1260.27 1190.2 ⚠️ -70.07
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-25 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-25 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-25 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-25 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-25 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-ver-25 Change
buildDuration 25.4s 25.5s ⚠️ +113ms
buildDurationCached 4.7s 4.4s -345ms
nodeModulesSize 339 MB 339 MB ⚠️ +15 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-ver-25 Change
/ failed reqs 0 0
/ total time (seconds) 4.131 4.17 ⚠️ +0.04
/ avg req/sec 605.17 599.45 ⚠️ -5.72
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.138 2.824 ⚠️ +0.69
/error-in-render avg req/sec 1169.38 885.39 ⚠️ -283.99
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-25 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-25 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-25 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-25 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-25 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: ed2e196

@kodiakhq kodiakhq bot merged commit 3146ed3 into vercel:canary Nov 20, 2021
@kdy1 kdy1 deleted the swc-ver-25 branch January 20, 2022 07:33
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
The purpose of this PR is to apply

 - swc-project/swc#2779
   - Fixes vercel#31291.
   - Not sure if it's fully fixed, but fixes some bugs related to vercel#31391 

 - swc-project/swc#2818
   - Fixes vercel#31627


I'll undraft this PR once swc-project/swc#2818 is fixed.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
@kdy1 kdy1 self-assigned this Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants