[update example - with-apollo-and-redux] pin dependencies #3130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweinan0423
changed the title
Member
|
Does the example work with v4? |
Contributor
Author
|
@timneutkens yep, next v4 requires react 16 |
timneutkens
reviewed
Oct 19, 2017
| "graphql": "^0.9.3", | ||
| "isomorphic-fetch": "^2.2.1", | ||
| "next": "latest", | ||
| "next": "^4", |
Contributor
Author
There was a problem hiding this comment.
sure. but when we get next 5 that might requires react 17, then we would need to do this again. But I think it's OK so users of this example would have to always use the latest React to play here
timneutkens
reviewed
Oct 19, 2017
| "next": "^4", | ||
| "prop-types": "^15.5.8", | ||
| "react": "^15.5.4", | ||
| "react": "^16", |
Member
There was a problem hiding this comment.
And make this ^16.0.0 for consistency
Member
|
Thanks @liweinan0423! If you update the 2 comments I had I'll merge it in 🙌 |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the combination
next@latestandreact@15is not working anymore as the latest next version requires react 16. so we need to pin the dependencies to specific versions