Sourcemap and Breakpoint Fixes

[kpdecker]

Fixes source maps so they work properly when run in concat chunks, pages, or dynamic chunks.
Updates files names in dev mode to be constant so breakpoints will persist across page refreshes.

Fixes #2990

[frol]

Won't this bring the mentioned issue #2014 back?

[kpdecker]

The disable cache feature in dev tools is on by default. Also cache management in dev mode is something devs should be aware of. It was one of the first things I learned back in the “old days” :)

…

On Tue, Oct 17, 2017 at 1:43 PM Vlad Frolov ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In server/render.js <#3121 (comment)>: > @@ -93,11 +93,9 @@ async function doRender (req, res, pathname, query, { } const docProps = await loadGetInitialProps(Document, { ...ctx, renderPage }) - // While developing, we should not cache any assets. - // So, we use a different buildId for each page load. - // With that we can ensure, we have unique URL for assets per every page load. - // So, it'll prevent issues like this: https://git.io/vHLtb - const devBuildId = Date.now() + // Hard coding build id to development to allow for breakpoints to be set across + // page reloads. + const devBuildId = 'development' Won't this bring the mentioned issue #2014 <#2014> back? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3121 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAL_Jpju2Pt__PkVrF1FRwTADOk6VLYLks5stPUSgaJpZM4P8Z1r> .

[kpdecker]

But headers also provide better fixes that allow both to live together.

…

On Tue, Oct 17, 2017 at 2:36 PM Kevin Decker ***@***.***> wrote: The disable cache feature in dev tools is on by default. Also cache management in dev mode is something devs should be aware of. It was one of the first things I learned back in the “old days” :) On Tue, Oct 17, 2017 at 1:43 PM Vlad Frolov ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In server/render.js > <#3121 (comment)>: > > > @@ -93,11 +93,9 @@ async function doRender (req, res, pathname, query, { > } > > const docProps = await loadGetInitialProps(Document, { ...ctx, renderPage }) > - // While developing, we should not cache any assets. > - // So, we use a different buildId for each page load. > - // With that we can ensure, we have unique URL for assets per every page load. > - // So, it'll prevent issues like this: https://git.io/vHLtb > - const devBuildId = Date.now() > + // Hard coding build id to development to allow for breakpoints to be set across > + // page reloads. > + const devBuildId = 'development' > > Won't this bring the mentioned issue #2014 > <#2014> back? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#3121 (review)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAL_Jpju2Pt__PkVrF1FRwTADOk6VLYLks5stPUSgaJpZM4P8Z1r> > . >

[kpdecker]

@frol pulled in the explicit no-cache headers from #2680 to help avoid any issues if not using dev tools, etc.

[timneutkens]

This is great @kpdecker, just tried and seems to work pretty well. One thing I noticed is that hot updates that contain errors (throw etc) don't get sourcemaps client side. Example:

export default class extends React.Component {
    render() {
        if(typeof window !== 'undefined') {
            throw new Error('Error')                   
        }
        return null
    }
}

[timneutkens]

Had to revert the PR:
#3134
#3135

[kpdecker]

I can reproduce #3134. Appears to be timing issue between the combine assets plugin and the uglify plugin. Investigating fix there.

I have not been able to reproduce #3135, but have subscribed and will note if the reporter provides more information.

[timneutkens]

Thanks @kpdecker ❤️

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.