Skip to content

Conversation

@kdy1
Copy link
Contributor

@kdy1 kdy1 commented Oct 26, 2021

We found that .swcrc was unintentionally loaded breaking applications as it is not tested for that yet, customization will be added at a later point in time

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

styfle
styfle previously approved these changes Oct 26, 2021
padmaia
padmaia previously approved these changes Oct 26, 2021
ijjk
ijjk previously approved these changes Oct 26, 2021
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once binaries are re-built

huozhi
huozhi previously approved these changes Oct 26, 2021
@ijjk

This comment has been minimized.

@github-actions github-actions bot dismissed stale reviews from huozhi, ijjk, padmaia, and styfle via a0ae930 October 26, 2021 23:18
@ijjk
Copy link
Member

ijjk commented Oct 26, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swcrc Change
buildDuration 20.6s 19.9s -662ms
buildDurationCached 4s 4.1s ⚠️ +141ms
nodeModulesSize 207 MB 207 MB ⚠️ +16.9 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swcrc Change
/ failed reqs 0 0
/ total time (seconds) 3.455 3.549 ⚠️ +0.09
/ avg req/sec 723.51 704.42 ⚠️ -19.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.92 1.797 -0.12
/error-in-render avg req/sec 1301.78 1391.11 +89.33
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swcrc Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swcrc Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swcrc Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swcrc Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swcrc Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swcrc Change
buildDuration 17s 16.5s -457ms
buildDurationCached 4.1s 3.9s -226ms
nodeModulesSize 207 MB 207 MB ⚠️ +16.9 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swcrc Change
/ failed reqs 0 0
/ total time (seconds) 3.618 3.43 -0.19
/ avg req/sec 691.03 728.95 +37.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.82 1.957 ⚠️ +0.14
/error-in-render avg req/sec 1373.82 1277.2 ⚠️ -96.62
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swcrc Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swcrc Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swcrc Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swcrc Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swcrc Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: d9e7d81

@kodiakhq kodiakhq bot merged commit a796ced into vercel:canary Oct 26, 2021
@kdy1 kdy1 deleted the swcrc branch October 26, 2021 23:56
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@kdy1 kdy1 self-assigned this Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants