-
Notifications
You must be signed in to change notification settings - Fork 30k
Move tracing next-server to next build #30190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
…to move/tracing-next-server
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
styfle
reviewed
Oct 22, 2021
styfle
reviewed
Oct 22, 2021
styfle
previously approved these changes
Oct 22, 2021
styfle
approved these changes
Oct 22, 2021
Member
Author
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| buildDuration | 13.4s | 12.6s | -764ms |
| buildDurationCached | 2.9s | 2.7s | -215ms |
| nodeModulesSize | 196 MB | 196 MB | -4.6 kB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.985 | 2.924 | -0.06 |
| / avg req/sec | 837.54 | 855.02 | +17.48 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.365 | 1.362 | 0 |
| /error-in-render avg req/sec | 1831.62 | 1835.52 | +3.9 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| 651.cd440d20..0b23.js gzip | 2.96 kB | 2.96 kB | ✓ |
| 831.695e33f6..205f.js gzip | 179 B | 179 B | ✓ |
| framework-89..a097.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-167207f..648c.js gzip | 26.1 kB | 26.1 kB | ✓ |
| webpack-f09b..493e.js gzip | 1.47 kB | 1.47 kB | ✓ |
| Overall change | 72.9 kB | 72.9 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| _app-9fb8765..c13d.js gzip | 979 B | 979 B | ✓ |
| _error-d828d..2954.js gzip | 3.06 kB | 3.06 kB | ✓ |
| amp-5388d1f5..4ce9.js gzip | 551 B | 551 B | ✓ |
| css-10424225..367a.js gzip | 329 B | 329 B | ✓ |
| dynamic-9821..3cd4.js gzip | 2.67 kB | 2.67 kB | ✓ |
| head-1df323b..d261.js gzip | 2.32 kB | 2.32 kB | ✓ |
| hooks-ab0016..b093.js gzip | 917 B | 917 B | ✓ |
| image-a42113..a670.js gzip | 5.84 kB | 5.84 kB | ✓ |
| index-95c8cb..6970.js gzip | 260 B | 260 B | ✓ |
| link-05c99e7..35ec.js gzip | 1.66 kB | 1.66 kB | ✓ |
| routerDirect..6659.js gzip | 319 B | 319 B | ✓ |
| script-d94ba..ed05.js gzip | 386 B | 386 B | ✓ |
| withRouter-7..8b2e.js gzip | 317 B | 317 B | ✓ |
| 9a34b27eb3f9..27d.css gzip | 125 B | 125 B | ✓ |
| Overall change | 19.7 kB | 19.7 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 458 B | 458 B | ✓ |
| Overall change | 458 B | 458 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| index.html gzip | 537 B | 537 B | ✓ |
| link.html gzip | 548 B | 548 B | ✓ |
| withRouter.html gzip | 528 B | 528 B | ✓ |
| Overall change | 1.61 kB | 1.61 kB | ✓ |
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| buildDuration | 6.2s | 5.9s | -284ms |
| buildDurationCached | 2.7s | 2.8s | |
| nodeModulesSize | 196 MB | 196 MB | -4.6 kB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.898 | 2.911 | |
| / avg req/sec | 862.74 | 858.75 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.367 | 1.384 | |
| /error-in-render avg req/sec | 1829.3 | 1806.77 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| 450.fd3ad245..022b.js gzip | 179 B | 179 B | ✓ |
| 675-759b108e..1b9a.js gzip | 13.8 kB | 13.8 kB | ✓ |
| framework-13..70b0.js gzip | 50.8 kB | 50.8 kB | ✓ |
| main-d78cd7f..aaf4.js gzip | 36.5 kB | 36.5 kB | ✓ |
| webpack-a7f2..2650.js gzip | 1.63 kB | 1.63 kB | ✓ |
| Overall change | 103 kB | 103 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| _app-ae91bc3..d985.js gzip | 1.33 kB | 1.33 kB | ✓ |
| _error-273ac..9ef0.js gzip | 180 B | 180 B | ✓ |
| amp-5f9a7694..99ce.js gzip | 315 B | 315 B | ✓ |
| css-3a1b2477..df1e.js gzip | 330 B | 330 B | ✓ |
| dynamic-e04a..a1b5.js gzip | 2.79 kB | 2.79 kB | ✓ |
| head-7f600d0..daa3.js gzip | 356 B | 356 B | ✓ |
| hooks-bd8c02..0730.js gzip | 638 B | 638 B | ✓ |
| image-6365b7..7506.js gzip | 536 B | 536 B | ✓ |
| index-80be94..e89f.js gzip | 262 B | 262 B | ✓ |
| link-4ee1ea7..8745.js gzip | 2.22 kB | 2.22 kB | ✓ |
| routerDirect..c4aa.js gzip | 325 B | 325 B | ✓ |
| script-67da0..49e6.js gzip | 390 B | 390 B | ✓ |
| withRouter-2..2409.js gzip | 322 B | 322 B | ✓ |
| 9a34b27eb3f9..27d.css gzip | 125 B | 125 B | ✓ |
| Overall change | 10.1 kB | 10.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 476 B | 476 B | ✓ |
| Overall change | 476 B | 476 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | ijjk/next.js move/tracing-next-server | Change | |
|---|---|---|---|
| index.html gzip | 535 B | 535 B | ✓ |
| link.html gzip | 546 B | 546 B | ✓ |
| withRouter.html gzip | 528 B | 528 B | ✓ |
| Overall change | 1.61 kB | 1.61 kB | ✓ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed this moves tracing
next-serverintonext buildsince the pre-trace at publish time isn't able to reliably give us file locations sincenode_modulefile locations can vary based on installation. This also adds caching the trace so that we only need to retracenext-serverwhen a lockfile changes.A follow-up PR will add documentation for these traces explaining how they can be leveraged.
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
yarn lint