Remove duplicate doctypes #28089
Merged
Remove duplicate doctypes #28089
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devknoll
requested review from
huozhi,
ijjk,
padmaia,
shuding,
styfle and
timneutkens
as code owners
styfle
reviewed
Aug 13, 2021
Member
styfle
left a comment
styfle
left a comment
There was a problem hiding this comment.
Thanks! Can you add a test to ensure this is working correctly?
shuding
previously approved these changes
Aug 13, 2021
ijjk
approved these changes
Aug 13, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| buildDuration | 12.2s | 11.3s | -872ms |
| buildDurationCached | 2.8s | 2.8s | |
| nodeModulesSize | 49.1 MB | 49.1 MB | -80 B |
Page Load Tests Overall increase ✓
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.322 | 2.303 | -0.02 |
| / avg req/sec | 1076.54 | 1085.37 | +8.83 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.341 | 1.221 | -0.12 |
| /error-in-render avg req/sec | 1864.41 | 2047.15 | +182.74 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| 745.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 23.1 kB | 23.1 kB | ✓ |
| webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
| Overall change | 67 kB | 67 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 980 B | 980 B | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 329 B | 329 B | ✓ |
| dynamic-HASH.js gzip | 2.64 kB | 2.64 kB | ✓ |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 904 B | 904 B | ✓ |
| image-HASH.js gzip | 4.13 kB | 4.13 kB | ✓ |
| index-HASH.js gzip | 261 B | 261 B | ✓ |
| link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
| routerDirect..HASH.js gzip | 319 B | 319 B | ✓ |
| script-HASH.js gzip | 387 B | 387 B | ✓ |
| withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 12.9 kB | 12.9 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 491 B | 491 B | ✓ |
| Overall change | 491 B | 491 B | ✓ |
Rendered Page Sizes Overall decrease ✓
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| index.html gzip | 541 B | 539 B | -2 B |
| link.html gzip | 553 B | 551 B | -2 B |
| withRouter.html gzip | 534 B | 532 B | -2 B |
| Overall change | 1.63 kB | 1.62 kB | -6 B |
Diffs
Diff for index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!DOCTYPE html>
+<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />Diff for link.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!DOCTYPE html>
+<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />Diff for withRouter.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!DOCTYPE html>
+<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| buildDuration | 9.4s | 8.9s | -563ms |
| buildDurationCached | 3.7s | 3.5s | -290ms |
| nodeModulesSize | 49.1 MB | 49.1 MB | -80 B |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.122 | 2.155 | |
| / avg req/sec | 1178.03 | 1160.07 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.183 | 1.185 | 0 |
| /error-in-render avg req/sec | 2112.87 | 2108.89 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| 16.HASH.js gzip | 186 B | 186 B | ✓ |
| 677f882d2ed8..HASH.js gzip | 14 kB | 14 kB | ✓ |
| framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
| main-HASH.js gzip | 10.6 kB | 10.6 kB | ✓ |
| webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
| Overall change | 67.9 kB | 67.9 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 965 B | 965 B | ✓ |
| _error-HASH.js gzip | 3.71 kB | 3.71 kB | ✓ |
| amp-HASH.js gzip | 552 B | 552 B | ✓ |
| css-HASH.js gzip | 333 B | 333 B | ✓ |
| dynamic-HASH.js gzip | 2.83 kB | 2.83 kB | ✓ |
| head-HASH.js gzip | 2.97 kB | 2.97 kB | ✓ |
| hooks-HASH.js gzip | 911 B | 911 B | ✓ |
| index-HASH.js gzip | 231 B | 231 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
| script-HASH.js gzip | 2.95 kB | 2.95 kB | ✓ |
| withRouter-HASH.js gzip | 294 B | 294 B | ✓ |
| e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 17.8 kB | 17.8 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 497 B | 497 B | ✓ |
| Overall change | 497 B | 497 B | ✓ |
Rendered Page Sizes Overall decrease ✓
| vercel/next.js canary | azukaru/next.js fix-duplicate-doctypes | Change | |
|---|---|---|---|
| index.html gzip | 585 B | 584 B | -1 B |
| link.html gzip | 598 B | 596 B | -2 B |
| withRouter.html gzip | 579 B | 577 B | -2 B |
| Overall change | 1.76 kB | 1.76 kB | -5 B |
Diffs
Diff for index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!DOCTYPE html>
+<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />Diff for link.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!DOCTYPE html>
+<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />Diff for withRouter.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!DOCTYPE html>
+<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
This was referenced Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a duplicate
DOCTYPE. This is already sent byrenderToHTML.