Update Fauna example with new guestbook #27295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-kurnikov
requested review from
huozhi,
ijjk,
leerob,
lfades,
padmaia,
shuding,
styfle and
timneutkens
as code owners
Contributor
|
I'm having trouble getting the setup script to run. Just me? |
leerob
reviewed
Jul 21, 2021
artem-kurnikov
force-pushed
the
with-fauna-example
branch
2 times, most recently
from
5b74e50 to
fddc4d6
Compare
leerob
previously approved these changes
Aug 2, 2021
leerob
reviewed
Aug 2, 2021
Contributor
leerob
left a comment
leerob
left a comment
There was a problem hiding this comment.
Looks like lint is failing - could you please fix that and then we can merge?
examples/with-fauna/package.json
Outdated
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2", | ||
| "request": "2.88.2", | ||
| "stream-to-promise": "3.0.0", |
Contributor
There was a problem hiding this comment.
Could this be moved to devDep?
Contributor
|
I've actually found a few places referencing the old example before being renamed - could you add a simple README to the old folder saying it's moved to |
artem-kurnikov
force-pushed
the
with-fauna-example
branch
from
6838084 to
0ccc25e
Compare
leerob
approved these changes
Aug 2, 2021
leerob
approved these changes
Aug 2, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
Based on vercel#26708 - Renames FaunaDB -> Fauna - Moves to Tailwind instead of bespoke styling - Use SWR instead of hand-rolled fetch wrapper - List/Create API for Guestbook - Preps for setting correct environment variables from Vercel integration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #26708