-
Notifications
You must be signed in to change notification settings - Fork 29.9k
Add page with next/image to stats-app #26973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f74177f
Add page with next/image to stats-app
ijjk aa9c214
Update stats-config
ijjk 89d7f32
Update globs
ijjk bcffc50
Only run prettier on js outputs
ijjk c72a530
Merge remote-tracking branch 'upstream/canary' into add/image-stats-page
ijjk f6b4580
only add image page for non-webpack 4 mode
ijjk b3fc938
update config
ijjk 7970d65
Merge remote-tracking branch 'upstream/canary' into add/image-stats-page
ijjk 2499b3d
Re-add moving page chunks
ijjk 218f88c
Merge branch 'canary' into add/image-stats-page
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import Image from 'next/image' | ||
| import logo from './nextjs.png' | ||
|
|
||
| function ImagePage(props) { | ||
| return ( | ||
| <> | ||
| <h1>next/image example</h1> | ||
| <Image src={logo} placeholder="blur" /> | ||
| </> | ||
| ) | ||
| } | ||
|
|
||
| // we add getServerSideProps to prevent static optimization | ||
| // to allow us to compare server-side changes | ||
| export const getServerSideProps = () => { | ||
| return { | ||
| props: {}, | ||
| } | ||
| } | ||
|
|
||
| export default ImagePage | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| const Page = () => 'Hello world 👋' | ||
|
|
||
| Page.getInitialProps = () => ({}) | ||
| // we add getServerSideProps to prevent static optimization | ||
| // to allow us to compare server-side changes | ||
| export const getServerSideProps = () => { | ||
| return { | ||
| props: {}, | ||
| } | ||
| } | ||
|
|
||
| export default Page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want a couple other usages, such as blur and external image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If either of these could impact the resulting client bundle differently it would be good to add these as well yeah, potentially in separate pages so we can see the impact separately
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I guess it won't affect the client bundle because all of the code for the image component lives in a single file.
The only thing that might affect the client bundle is config in
next.config.jswhen that gets serialized to JSON, but thats a 1-to-1 mapping so we don't really need to test it here 👍