Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(create-next-app): assert for typescript template dependencies #25214

Merged
merged 1 commit into from
May 19, 2021

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented May 18, 2021

This PR aims at updating the create-next-app test suite to include an assertion for the dependencies specific to the typescript template.

if (typescript) {
devDependencies.push('typescript', '@types/react')
}

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented May 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
buildDuration 12.1s 12.2s ⚠️ +36ms
buildDurationCached 3.8s 3.7s -42ms
nodeModulesSize 46.7 MB 46.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
/ failed reqs 0 0
/ total time (seconds) 2.059 2.087 ⚠️ +0.03
/ avg req/sec 1214.22 1197.68 ⚠️ -16.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.057 1.037 -0.02
/error-in-render avg req/sec 2365.17 2411.91 +46.74
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
index.html gzip 561 B 561 B
link.html gzip 569 B 569 B
withRouter.html gzip 557 B 557 B
Overall change 1.69 kB 1.69 kB

Serverless Mode (Decrease detected ✓)
General
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
buildDuration 14.4s 14.4s ⚠️ +42ms
buildDurationCached 4.6s 4.6s ⚠️ +30ms
nodeModulesSize 46.7 MB 46.7 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Serverless bundles Overall decrease ✓
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
_error.js 17 kB 17 kB -6 B
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 17.3 kB 17.3 kB
link.js 17.6 kB 17.6 kB
routerDirect.js 17.5 kB 17.5 kB
withRouter.js 17.6 kB 17.6 kB
Overall change 108 kB 108 kB -6 B

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
buildDuration 10.4s 10.7s ⚠️ +237ms
buildDurationCached 4.4s 4.4s -37ms
nodeModulesSize 46.7 MB 46.7 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
/ failed reqs 0 0
/ total time (seconds) 2.108 2.101 -0.01
/ avg req/sec 1185.93 1190.17 +4.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.11 1.132 ⚠️ +0.02
/error-in-render avg req/sec 2251.95 2208.42 ⚠️ -43.53
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.26 kB 7.26 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.38 kB 9.38 kB
Client Build Manifests
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary jamesgeorge007/next.js test/create-next-app Change
index.html gzip 613 B 613 B
link.html gzip 621 B 621 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB
Commit: 1f7aaa8

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

This was referenced May 19, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
…ercel#25214)

This PR aims at updating the `create-next-app` test suite to include an assertion for the dependencies specific to the typescript template.
https://github.com/vercel/next.js/blob/218c6114c9f5ed5c6d65840037673c841f44536b/packages/create-next-app/create-app.ts#L214-L216
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants