Skip to content

Conversation

@oliviertassinari
Copy link
Contributor

@oliviertassinari oliviertassinari commented Jun 23, 2017

Errors bubbles up, to reproduce the issue throw an error deep in a render method. You will see the console.error hit many times.

@timneutkens timneutkens requested a review from arunoda June 26, 2017 19:43
@timneutkens
Copy link
Member

@arunoda can you check this out?

@arunoda arunoda self-assigned this Jun 27, 2017
@arunoda
Copy link
Contributor

arunoda commented Jun 27, 2017

@oliviertassinari could you send me a way to test this out?
What's the use case which this applies?
Basically, I need a way to test this locally.

@oliviertassinari
Copy link
Contributor Author

@arunoda
Copy link
Contributor

arunoda commented Jul 2, 2017

Thanks. This looks great.

@arunoda arunoda merged commit a07c7c4 into vercel:v3-beta Jul 2, 2017
@arunoda arunoda removed their request for review July 2, 2017 06:29
@timneutkens
Copy link
Member

👍

@oliviertassinari oliviertassinari deleted the patch-1 branch July 2, 2017 09:53
@lock lock bot locked as resolved and limited conversation to collaborators Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants