-
Notifications
You must be signed in to change notification settings - Fork 29.9k
implement next/static #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement next/static #2241
Conversation
| const moduleName = 'next/static' | ||
| const staticStats = {} | ||
| const staticStatsPath = process.env.__NEXT_STATIC_STATS_PATH__ | ||
| const staticDir = process.env.__NEXT_STATIC_DIR__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need better way to tell babel plugin where the static dir is located
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cloudkite I wonder if it would make sense for the static location to somehow be configured / set as part of config: https://github.com/zeit/next.js/blob/master/server/config.js
I know it's not configurable at the moment, but getConfig has access to dir and the result is cached / stored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kochis not sure when I'll get a chance to pick this up, feel free to jump in :)
|
@cloudkite Thanks for the PR. |
|
ok no problem 👍 |
|
This feature is actually the last remaining blocker for us rolling out with next.js. We'll probably roll these changes in if needed, but if there's any chance of getting this into an upcoming release, that would be 👌 More than happy to help out with anything on this as well. |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
based on discussion in #1473
__NEXT_STATIC_STATS_PATH__and__NEXT_STATIC_DIR__