Skip to content

Conversation

@cloudkite
Copy link
Contributor

@cloudkite cloudkite commented Jun 13, 2017

based on discussion in #1473

  • needs tests
  • guidance on how to remove __NEXT_STATIC_STATS_PATH__ and __NEXT_STATIC_DIR__

const moduleName = 'next/static'
const staticStats = {}
const staticStatsPath = process.env.__NEXT_STATIC_STATS_PATH__
const staticDir = process.env.__NEXT_STATIC_DIR__
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need better way to tell babel plugin where the static dir is located

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cloudkite I wonder if it would make sense for the static location to somehow be configured / set as part of config: https://github.com/zeit/next.js/blob/master/server/config.js

I know it's not configurable at the moment, but getConfig has access to dir and the result is cached / stored.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kochis that could work 👍 @arunoda what do you think of this approach?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kochis not sure when I'll get a chance to pick this up, feel free to jump in :)

@arunoda
Copy link
Contributor

arunoda commented Jun 13, 2017

@cloudkite Thanks for the PR.
But currently we are in a feature freeze stage for Next 3.0
Once we release that, let's have a deeper look at this.

@cloudkite
Copy link
Contributor Author

ok no problem 👍

@kochis
Copy link

kochis commented Aug 17, 2017

This feature is actually the last remaining blocker for us rolling out with next.js. We'll probably roll these changes in if needed, but if there's any chance of getting this into an upcoming release, that would be 👌

More than happy to help out with anything on this as well.

@cloudkite cloudkite closed this Oct 9, 2017
@cloudkite cloudkite deleted the static-hashing branch November 9, 2017 00:30
@lock
Copy link

lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants