Skip to content

Warn when Fast Refresh is disabled (React <16.10) #15931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 6, 2020
Merged

Warn when Fast Refresh is disabled (React <16.10) #15931

merged 7 commits into from
Aug 6, 2020

Conversation

@Timer
Copy link
Member

@Timer Timer commented Aug 6, 2020 •
edited
Loading

This emits a warning when we detect a React version before 16.10, which disables Fast Refresh.

Despite adding the semver package, this actually reduces our install size by -5.02 kB because we deduped numerous other versions in our bundled packages!

Fixes #14900
Closes #13968

@ijjk ijjk added the type: next label Aug 6, 2020
@ijjk
Copy link
Member

ijjk commented Aug 6, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
buildDuration 13.6s 13.6s -47ms
nodeModulesSize 66 MB 66 MB -5.02 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js preflight/react-version Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.535 2.606 ⚠️ +0.07
/ avg req/sec 986.01 959.26 ⚠️ -26.75
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.625 1.598 -0.03
/error-in-render avg req/sec 1538.83 1564.26 +25.43
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-da9f477..d581.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js preflight/react-version Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js preflight/react-version Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js preflight/react-version Change
index.html gzip 947 B 947 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
buildDuration 15s 15s ⚠️ +3ms
nodeModulesSize 66 MB 66 MB -5.02 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-da9f477..d581.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js preflight/react-version Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js preflight/react-version Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js preflight/react-version Change
_error.js 1.02 MB 1.03 MB ⚠️ +6.52 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.03 MB ⚠️ +6.52 kB
link.js 1.06 MB 1.07 MB ⚠️ +6.52 kB
routerDirect.js 1.05 MB 1.06 MB ⚠️ +6.52 kB
withRouter.js 1.05 MB 1.06 MB ⚠️ +6.52 kB
Overall change 5.22 MB 5.25 MB ⚠️ +32.6 kB
Commit: baa1224

@ijjk
Copy link
Member

ijjk commented Aug 6, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
buildDuration 12.2s 12.8s ⚠️ +623ms
nodeModulesSize 66 MB 66 MB -5.02 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js preflight/react-version Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.215 2.296 ⚠️ +0.08
/ avg req/sec 1128.67 1088.95 ⚠️ -39.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.202 1.225 ⚠️ +0.02
/error-in-render avg req/sec 2079.2 2040.51 ⚠️ -38.69
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-da9f477..d581.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js preflight/react-version Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js preflight/react-version Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js preflight/react-version Change
index.html gzip 947 B 947 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
buildDuration 13.5s 13.9s ⚠️ +396ms
nodeModulesSize 66 MB 66 MB -5.02 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-da9f477..d581.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js preflight/react-version Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js preflight/react-version Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js preflight/react-version Change
_error.js 1.02 MB 1.03 MB ⚠️ +6.52 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.03 MB ⚠️ +6.52 kB
link.js 1.06 MB 1.07 MB ⚠️ +6.52 kB
routerDirect.js 1.05 MB 1.06 MB ⚠️ +6.52 kB
withRouter.js 1.05 MB 1.06 MB ⚠️ +6.52 kB
Overall change 5.22 MB 5.25 MB ⚠️ +32.6 kB
Commit: 41fa29d

@Timer Timer marked this pull request as ready for review August 6, 2020 05:41
@ijjk
Copy link
Member

ijjk commented Aug 6, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
buildDuration 13.4s 13.5s ⚠️ +34ms
nodeModulesSize 66 MB 66 MB -4.77 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.511 2.523 ⚠️ +0.01
/ avg req/sec 995.56 990.96 ⚠️ -4.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.55 1.507 -0.04
/error-in-render avg req/sec 1612.83 1658.56 +45.73
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-da9f477..d581.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js preflight/react-version Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js preflight/react-version Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js preflight/react-version Change
index.html gzip 947 B 947 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
buildDuration 15.7s 14.7s -963ms
nodeModulesSize 66 MB 66 MB -4.77 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-da9f477..d581.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js preflight/react-version Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js preflight/react-version Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js preflight/react-version Change
_error.js 1.02 MB 1.03 MB ⚠️ +6.52 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.03 MB ⚠️ +6.52 kB
link.js 1.06 MB 1.07 MB ⚠️ +6.52 kB
routerDirect.js 1.05 MB 1.06 MB ⚠️ +6.52 kB
withRouter.js 1.05 MB 1.06 MB ⚠️ +6.52 kB
Overall change 5.22 MB 5.25 MB ⚠️ +32.6 kB
Commit: 499b37e

ijjk
ijjk previously approved these changes Aug 6, 2020
View reviewed changes
@timneutkens
Merge branch 'canary' of github.com:vercel/next.js into Timer-preflig…
5f51f52 
…ht/react-version

# Conflicts:
#	packages/next/cli/next-dev.ts
#	test/integration/cli/test/index.test.js
@ijjk
Copy link
Member

ijjk commented Aug 6, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
buildDuration 12.3s 12.8s ⚠️ +529ms
nodeModulesSize 66 MB 66 MB -4.78 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.327 2.258 -0.07
/ avg req/sec 1074.57 1107.18 +32.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.5 1.442 -0.06
/error-in-render avg req/sec 1666.67 1734.25 +67.58
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-da9f477..d581.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js preflight/react-version Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js preflight/react-version Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js preflight/react-version Change
index.html gzip 947 B 947 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js preflight/react-version Change
buildDuration 15s 14.4s -600ms
nodeModulesSize 66 MB 66 MB -4.78 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..8895.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-da9f477..d581.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
677f882d2ed8..dule.js gzip 6.21 kB 6.21 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-ccc9938..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.9 kB 51.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js preflight/react-version Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js preflight/react-version Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js preflight/react-version Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js preflight/react-version Change
_error.js 1.02 MB 1.03 MB ⚠️ +6.52 kB
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.03 MB ⚠️ +6.52 kB
link.js 1.06 MB 1.07 MB ⚠️ +6.52 kB
routerDirect.js 1.05 MB 1.06 MB ⚠️ +6.52 kB
withRouter.js 1.05 MB 1.06 MB ⚠️ +6.52 kB
Overall change 5.22 MB 5.25 MB ⚠️ +32.6 kB
Commit: 5f51f52

@Timer Timer requested a review from ijjk August 6, 2020 14:38
@Timer
Copy link
Member Author

Timer commented Aug 6, 2020

Landing due to prior approval

@Timer Timer changed the title Next.js should warn when Fast Refresh is disabled (React <16.10) Warn when Fast Refresh is disabled (React <16.10) Aug 6, 2020
@Timer Timer merged commit 882288b into vercel:canary Aug 6, 2020
@Timer Timer deleted the preflight/react-version branch August 6, 2020 14:41
@sync
Copy link
Contributor

sync commented Aug 13, 2020 •
edited
Loading

I understand this got merged already but disable hmr for React experimental it’s unfortunate

@timneutkens
Copy link
Member

timneutkens commented Aug 13, 2020

See #16103, this is just a warning, it's not disabling fast refresh. The warning is being updated to not show in React experimental versions

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Next.js should warn and encourage upgrade on React <16.10

4 participants

@Timer @ijjk @sync @timneutkens