-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Babel cache #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel cache #1369
Conversation
| "dev": "next", | ||
| "build": "next build", | ||
| "clean": "rimraf .\\node_modules\\.cache", | ||
| "build-dev": "npm run clean && next build --env=development", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not simply
"build-dev": "npm run clean && next build",
"build-prod": "npm run clean && NODE_ENV=production next build"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we need to pass additional parameters like instance (we need to pass 2 params)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then can just add another env var.
IMHO that's unrelated to what the example is trying to convey. There's no need for command-line-args to get universal config working.
| "react-dom": "^15.4.2" | ||
| }, | ||
| "devDependencies": { | ||
| "command-line-args": "^4.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't understand why this package was needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this package makes params from command line easy to collect
|
@arunoda the babel-loader caching issue here makes me think we should clear |
|
@timneutkens then in development, it won't get used. In the deployment we could clean it, but I rather let it to be done by the user. |
|
@arunoda yeah lets document the way someone has to clear the cache instead of flushing it ourselves. |
|
Closing this in favor of #1432. |
Fix problem with babel cache problem, ability to switch versions with command line args