Skip to content

Conversation

@Timer
Copy link
Member

@Timer Timer commented May 9, 2020

This reorders the fast refresh loader so that it does not influence Babel syntax errors, obscuring the real problem.

Without this, the user sees something like:

    SyntaxError: /Users/joe/Documents/Development/Work/zeit/next.js-extra/test/acceptance/__tmp__/fiuG3UK5eJ3kqLTI4GNv5/index.js: Unexpected token (17:8)

      15 |     // browser context before continuing.
      16 |     if (typeof self !== 'undefined') {
    > 17 |         var currentExports_1 = module.__proto__.exports;
         |         ^
      18 |         var prevExports = (_b = (_a = module.hot.data) === null || _a === void 0 ? void 0 : _a.prevExports) !== null && _b !== void 0 ? _b : null;
      19 |         // This cannot happen in MainTemplate because the exports mismatch between
      20 |         // templating and execution.

@Timer Timer added this to the 9.3.7 milestone May 9, 2020
@Timer Timer requested review from ijjk, lfades and timneutkens as code owners May 9, 2020 22:10
@Timer Timer merged commit f54e05f into canary May 9, 2020
@Timer Timer deleted the hotfix/unterminated-jsx branch May 9, 2020 22:37
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants