Skip to content

Fix status messages on error #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2017
Merged

Fix status messages on error #1131

merged 2 commits into from
Feb 14, 2017

Conversation

@nkzawa
Copy link
Contributor

@nkzawa nkzawa commented Feb 14, 2017

This PR fixes that Internal Server Error is shown even when statusCode is 403, for example.

timneutkens
timneutkens approved these changes Feb 14, 2017
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@timneutkens timneutkens merged commit 45e77d5 into master Feb 14, 2017
@timneutkens timneutkens deleted the fix/error-status-messages branch February 14, 2017 15:16
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nkzawa @timneutkens