HMR not working

[prathameshnetake]

Bug report

Hot module reload as well as refresh server on changes stops working if project directory name contain dots e.g. username.github.io

System information

Replicated on Windows and linux Ubuntu

[timneutkens]

What version of Next.js are you on?

[prathameshnetake]

My package.json looks like this

{
"dependencies": {
"@material-ui/core": "^3.1.1",
"@material-ui/icons": "^3.0.1",
"next": "latest",
"react": "latest",
"react-dom": "latest",
"react-jss": "latest"
},
"scripts": {
"dev": "next",
"build": "next build && next export && rm -rf _next && cp -r out/* . && rm -rf out",
"start": "next start",
"help": "next export -h"
},
"devDependencies": {
"babel-eslint": "^8.2.1",
"eslint": "^4.17.0",
"eslint-loader": "^1.9.0",
"eslint-plugin-react": "^7.6.1"
},
"name": "prathameshnetake.github.io",
"version": "1.0.0",
"main": "index.js",
"repository": "https://prathameshnetake@github.com/prathameshnetake/prathameshnetake.github.io",
"author": "Prathamesh prathamesh.netake@gmail.com",
"license": "MIT"
}

[vinpac]

I've tested on next 7.0.2 and it seems HMR doesn't work when warnings are thrown

When I removed the code that was causing the warnings, the HMR started working again.

I consider this an error for 2 reasons:

1. These warning don't are wrong. Because the 2 interfaces are being exported. (Maybe a mistake from my part configuring babel? I don't know yet. But it worked fine in next 6 )
2. If it's blocking the update it should be an error not a warning.

[OutThisLife]

I get this too, anything scoped beneath _app.tsx fails to reload any changes.

[jagaapple]

What @vinpac saying is true. When some warnings are thrown, HMR is blocked.
In particular, TypeScript developers not using isolatedModules flag cannot avoid these warnings, I think we should not make them to errors and add an option to disable these warnings.

https://github.com/zeit/next.js/blob/b1c4f3aec4ca2d51b0ed849914cc8fc97805740a/packages/next/client/dev-error-overlay/format-webpack-messages.js#L115

[prathameshnetake]

@jagaapple True. Warnings also come if you use material UI with next.js. You can also suppress them. My concern is if you initiate whole whole project into directory and that directory name contains multiple dots e.g. abc.abc.abc then HMR breaks.

[timneutkens]

We only ignore these paths for HMR: https://github.com/zeit/next.js/blob/canary/packages/next/server/hot-reloader.js#L313-L317

[ritz078]

Same was the error for me. Nothing happened even if changed something. I remove . from my directory name and everything started working perfectly.

[to-var]

I also noticed HMR not working since version 7.0.0

OS, Node, and NPM info:

- Using: MacOS Mojave
- Node version: v10.12.0
- NPM version: 6.4.1

Package.json:

  "dependencies": {
    "next": "^7.0.2",
    "react": "^16.5.2",
    "react-dom": "^16.5.2",
  },
  "devDependencies": {}

There are no warnings on neither terminal or devtools.

I've tried using those same dependencies with Next version 6.1.2 and worked fine.

[guivr]

+1. Warnings

[elmasse]

Hello guys,

I found myself trap by this bug too. I tested a lot of project names:

• test.github.io
• next.gitio
• next.git.io
• test.gitw

None of them works, you can see a pattern there. I finally found a workaround by overriding the watchOptions in the next.config.js:

module.exports = {
  webpackDevMiddleware(config) {
    config.watchOptions = {
      ignored: [
        /\.git\//,
        /\.next\//,
        /node_modules/
      ]
    }
    return config;
  }
}

This seems to be working with all the cases I mentioned. So probably the offending line is the one that @timneutkens pointed out in a previous comment https://github.com/zeit/next.js/blob/canary/packages/next/server/hot-reloader.js#L313-L317

My 2 cents!

BTW, Thanks everyone for such an awesome work on next!