with-passport-and-next-connect redefines response `end` function as async

[ntaranov]

Verify canary release

• I verified that the issue exists in the latest Next.js canary release

Provide environment information

---

Which example does this report relate to?

with-passport-and-next-connect

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

Describe the Bug

Here in with-passport-and-next-connect end function is defined as async. This cannot be correct as it's called without await by the framework creating a race condition.

This is a result of

• Trying to override sync end
• Using async @hapi\iron apis

Expected Behavior

This can be fixed either by saving the session somewhere else or by using a sync cryptography API.

To Reproduce

Run the example, see API resolved without sending a response for /api/auth/session, this may result in stalled requests. in the console.

[mause-01]

The issue you're encountering with the "with-passport-and-next-connect" package is that it redefines the response end function as async, which is causing conflicts. To fix this issue, you can try the following solution:

1.Open the file where the issue is occurring (e.g., the file where you're using the "with-passport-and-next-connect" package).

2.Look for the section of code that redefines the response end function. It might be something like res.end = async function() { ... }.

3. Modify the code to remove the async keyword from the function definition. For example, change it to res.end = function() { ... }.

Save the file and restart your Next.js server

[ntaranov]

The issue you're encountering with the "with-passport-and-next-connect" package is that it redefines the response end function as async, which is causing conflicts. To fix this issue, you can try the following solution:

1.Open the file where the issue is occurring (e.g., the file where you're using the "with-passport-and-next-connect" package).

2.Look for the section of code that redefines the response end function. It might be something like res.end = async function() { ... }.

3. Modify the code to remove the async keyword from the function definition. For example, change it to res.end = function() { ... }.

Save the file and restart your Next.js server

I sorts of explained this option in my initial report, the problem is that the example relies on @hapi\iron methods that are async only, which I also explained.

[Aakashdeep-Srivastava]

Lets do this.... Assign this to me.

I am new to open source. Please let me know if this has been resolved or not. Also if possible give me a brief about the issue. So that i can resolve it. Any help would be appreciated.

Can i get a brief about this issue?

I am able to reproduce this when i am sending a GET request to api/login.