Skip to content

Commit

Permalink
ensure e2e tests workflow doesnt skip postinstall
Browse files Browse the repository at this point in the history
  • Loading branch information
ztanner committed Sep 4, 2024
1 parent e1f3419 commit d967bbc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/build_reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ on:
required: false
description: 'whether to skip building native modules'
type: string
skipNativeInstall:
required: false
description: 'whether to skip native postinstall script'
type: string
uploadAnalyzerArtifacts:
required: false
description: 'whether to upload analyzer artifacts'
Expand Down Expand Up @@ -71,9 +75,8 @@ env:
TURBO_TEAM: 'vercel'
TURBO_REMOTE_ONLY: 'true'
NEXT_TELEMETRY_DISABLED: 1
# we build a dev binary for use in CI so skip downloading
# canary next-swc binaries in the monorepo
NEXT_SKIP_NATIVE_POSTINSTALL: 1
# allow not skipping install-native postinstall script if we don't have a binary available already
NEXT_SKIP_NATIVE_POSTINSTALL: ${{ inputs.skipNativeInstall != 'yes' && 'true' || '' }}
DATADOG_API_KEY: ${{ secrets.DATA_DOG_API_KEY }}
NEXT_JUNIT_TEST_REPORT: 'true'
DD_ENV: 'ci'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test_e2e_deploy_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@ jobs:
NEXT_TEST_SWC_PACKAGE_NAME="@next/swc-linux-x64-gnu"
NEXT_TEST_SWC_PACKAGE_VERSION="https://vercel-packages.vercel.app/next/commits/${{ github.sha }}/@next/swc-linux-x64-gnu"
NEXT_EXTERNAL_TESTS_FILTERS="test/deploy-tests-manifest.json"
NEXT_TEST_CONTINUE_ON_ERROR="1"
node run-tests.js --timings -g ${{ matrix.group }} -c 2 --type e2e
skipNativeBuild: 'yes'
skipNativeInstall: 'yes'
stepName: 'test-deploy-${{ matrix.group }}'
timeout_minutes: 180
runs_on_labels: '["ubuntu-latest"]'
Expand Down

0 comments on commit d967bbc

Please sign in to comment.