clippy

vercel · Oct 16, 2023 · c731770 · c731770
1 parent 9cd757e
commit c731770
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/packages/next-swc/crates/core/src/cjs_optimizer.rs b/packages/next-swc/crates/core/src/cjs_optimizer.rs
@@ -233,7 +233,7 @@ impl VisitMut for CjsOptimizer {
                                         self.data.imports.insert(
                                             key,
                                             ImportRecord {
-                                                module_specifier: v.value.clone().into(),
+                                                module_specifier: v.value.clone(),
                                             },
                                         );
                                     }

diff --git a/packages/next-swc/crates/core/src/optimize_server_react.rs b/packages/next-swc/crates/core/src/optimize_server_react.rs
@@ -68,7 +68,7 @@ impl Fold for OptimizeServerReact {
             new_items.push(item.clone().fold_with(self));
 
             if let ModuleItem::ModuleDecl(ModuleDecl::Import(import_decl)) = &item {
-                if import_decl.src.value.to_string() != "react" {
+                if import_decl.src.value != "react" {
                     continue;
                 }
                 for specifier in &import_decl.specifiers {
@@ -119,9 +119,7 @@ impl Fold for OptimizeServerReact {
                         if &f.to_id() == react_ident {
                             if let MemberProp::Ident(i) = &member.prop {
                                 // Remove `React.useEffect` and `React.useLayoutEffect` calls
-                                if i.sym.to_string() == "useEffect"
-                                    || i.sym.to_string() == "useLayoutEffect"
-                                {
+                                if i.sym == "useEffect" || i.sym == "useLayoutEffect" {
                                     return Expr::Lit(Lit::Null(Null { span: DUMMY_SP }));
                                 }
                             }

diff --git a/packages/next-swc/crates/core/src/page_config.rs b/packages/next-swc/crates/core/src/page_config.rs
@@ -77,7 +77,7 @@ impl Fold for PageConfig {
             for decl in &var_decl.decls {
                 let mut is_config = false;
                 if let Pat::Ident(ident) = &decl.name {
-                    if &ident.id.sym == CONFIG_KEY {
+                    if ident.id.sym == CONFIG_KEY {
                         is_config = true;
                     }
                 }
@@ -151,14 +151,14 @@ impl Fold for PageConfig {
         match &specifier.exported {
             Some(ident) => {
                 if let ModuleExportName::Ident(ident) = ident {
-                    if &ident.sym == CONFIG_KEY {
+                    if ident.sym == CONFIG_KEY {
                         self.handle_error("Config cannot be re-exported.", specifier.span)
                     }
                 }
             }
             None => {
                 if let ModuleExportName::Ident(ident) = &specifier.orig {
-                    if &ident.sym == CONFIG_KEY {
+                    if ident.sym == CONFIG_KEY {
                         self.handle_error("Config cannot be re-exported.", specifier.span)
                     }
                 }